Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java): upgrade java extension to 0.75.0 and quarkus to v1.7.0 #516

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

sunix
Copy link
Contributor

@sunix sunix commented Jun 8, 2021

What does this PR do?

upgrade java extension to 0.75.0 and quarkus to v1.7.0
also adding the microprofile extension which is a requirement for quarkus extension

What issues does this PR fix or reference?

Quarkus: https://issues.redhat.com/browse/CRW-1697
Java: https://issues.redhat.com/browse/CRW-1699
upstream PR:

Release Notes

Docs PR (if applicable)

@nickboldt
Copy link
Member

Has this been verified against openj9?

Copy link
Member

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect @benoitf will reject this because it doesn't conform to the issue template and doesn't mention a JIRA.

(I'm more flexible, but also like to see a JIRA # linked from PRs when possible.) :)

Note that the linelint problem is unrelated, [EOF Rule] File "product/buildAllInBrewCopyToQuay.sh" has lint errors is my fault and I've fixed it already in the 2 and 2.9 branches ... but PR check won't be re-run here.

@svor or @ericwill if you like this, please merge it in crw-2 branch only (unless it's a blocker for 2.9 too).

@nickboldt nickboldt requested a review from svor June 9, 2021 01:21
@sunix
Copy link
Contributor Author

sunix commented Jun 9, 2021

Has this been verified against openj9?

I have not tested with openj9 but as these ones are not impacting the sidecars it should be ok.

@sunix sunix changed the title fix(java): upgrade java extension to 0.75.0 and quarkus to v1.7.0 feat(java): upgrade java extension to 0.75.0 and quarkus to v1.7.0 Jun 9, 2021
@sunix
Copy link
Contributor Author

sunix commented Jun 9, 2021

please do not merge yet, there is a problem (strangely the extension works after a refresh)
Selection_395

@svor
Copy link
Contributor

svor commented Jun 9, 2021

@sunix the problem could be related to https://issues.redhat.com/browse/CRW-1793

@sunix
Copy link
Contributor Author

sunix commented Jun 9, 2021

Yes unrelated to my changes I have just tested without and have the same issue. This is ok !

@nickboldt nickboldt merged commit 866c9c5 into crw-2-rhel-8 Jun 9, 2021
@nickboldt nickboldt deleted the java-0_75_0 branch June 9, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants