Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move from github.com/feloy/devfile-builder #6937

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Move from github.com/feloy/devfile-builder #6937

merged 2 commits into from
Jun 29, 2023

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Jun 28, 2023 •
edited
Loading

What type of PR is this:

/kind feature

Importd the Devfile builder sources from github.com/feloy/devfile-builder

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6899

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Jun 28, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit e8c3fa9
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/649d3f152223c00008280b03

@openshift-ci openshift-ci bot requested review from anandrkskd and rm3l June 28, 2023 07:15
@feloy feloy changed the title Move from github.com/feloy/devfile-builder [wip] Move from github.com/feloy/devfile-builder Jun 28, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 28, 2023
@odo-robot
Copy link

odo-robot bot commented Jun 28, 2023 •
edited
Loading

Validate Tests on commit 7288b18 finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the feature-6899/devfile-builder-init branch from a68e052 to d4a8fc4 Compare June 28, 2023 07:18
@odo-robot
Copy link

odo-robot bot commented Jun 28, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 7288b18 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 28, 2023 •
edited
Loading

NoCluster Tests on commit 7288b18 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 28, 2023 •
edited
Loading

Unit Tests on commit 7288b18 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 28, 2023 •
edited
Loading

Kubernetes Tests on commit 7288b18 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 28, 2023 •
edited
Loading

OpenShift Tests on commit 7288b18 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 28, 2023 •
edited
Loading

Windows Tests (OCP) on commit 7288b18 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 28, 2023 •
edited
Loading

Kubernetes Docs Tests on commit ce1d824 finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the feature-6899/devfile-builder-init branch from d4a8fc4 to 4edcc1b Compare June 28, 2023 07:57
@feloy feloy changed the title [wip] Move from github.com/feloy/devfile-builder Move from github.com/feloy/devfile-builder Jun 28, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 28, 2023
@feloy feloy removed the request for review from anandrkskd June 28, 2023 08:14
@rm3l rm3l mentioned this pull request Jun 28, 2023
Merged
3 tasks
@feloy feloy force-pushed the feature-6899/devfile-builder-init branch from 4edcc1b to 3c065e0 Compare June 28, 2023 15:32
rm3l
rm3l requested changes Jun 29, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can you add a GitHub Workflow to check that the wasm module builds correctly?

.github/workflows/ui-e2e.yaml Outdated Show resolved Hide resolved
ui/Makefile Show resolved Hide resolved
ui/wasm/go.mod Show resolved Hide resolved
@feloy
Copy link
Contributor Author

feloy commented Jun 29, 2023

Also, can you add a GitHub Workflow to check that the wasm module builds correctly?

This wasm module will be removed with the next PR I'm working on, I would not bother with it

@feloy @rm3l
Update .github/workflows/ui-e2e.yaml
e8c3fa9 
Co-authored-by: Armel Soro <armel@rm3l.org>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rm3l
Copy link
Member

rm3l commented Jun 29, 2023

Also, can you add a GitHub Workflow to check that the wasm module builds correctly?

This wasm module will be removed with the next PR I'm working on, I would not bother with it

Ah yes, I forgot this. Indeed, makes sense then.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 29, 2023
@rm3l rm3l added the kind/task Issue is actionable task label Jun 29, 2023
@openshift-merge-robot openshift-merge-robot merged commit 6a4e964 into redhat-developer:main Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

Assignees

@rm3l rm3l

Labels
kind/task Issue is actionable task lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Devfile Builder UI PoC into odo (as separate frontend app)
3 participants
@feloy @rm3l @openshift-merge-robot