Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .gitattributes file with Git-style path matchers customizing how PR changed files appear on GitHub #6940

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Add .gitattributes file with Git-style path matchers customizing how PR changed files appear on GitHub #6940

merged 1 commit into from
Jun 28, 2023

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Jun 28, 2023 •
edited
Loading

What type of PR is this:
/kind task

What does this PR do / why we need it:
GitHub UI is terribly slow when reviewing/commenting on PRs that contain a lot of changes in the vendored directories, like in #6937
As suggested in [1], we can keep certain files from displaying in diffs by default, by using a standard .gitattributes file.
This should make it easier to review large PRs with a lot of changes from certain files (like in **/vendor/**), by hiding them by default.

[1] https://docs.github.com/en/repositories/working-with-files/managing-files/customizing-how-changed-files-appear-on-github f

This is how matching files would appear if linguist-generated attribute is true; so it will still be possible to show the diff on demand if needed:
image

Which issue(s) this PR fixes:
—

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@rm3l
Add .gitattributes file with Git-style path matches customizing how c…
8f55e1c 
…hanged files appear on GitHub

This should make it easier to review large PRs
with a lot of changes from certain files
(like in `**/vendor/**`), by hiding them by default.
@openshift-ci openshift-ci bot added the kind/task Issue is actionable task label Jun 28, 2023
@netlify
Copy link

netlify bot commented Jun 28, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 8f55e1c
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/649c32582b7785000828662e

@openshift-ci openshift-ci bot requested review from anandrkskd and valaparthvi June 28, 2023 13:15
@rm3l rm3l requested review from feloy and removed request for anandrkskd June 28, 2023 13:15
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odo-robot
Copy link

odo-robot bot commented Jun 28, 2023

OpenShift Unauthenticated Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 28, 2023

NoCluster Tests on commit finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 28, 2023

Unit Tests on commit finished successfully.
View logs: TXT HTML

@rm3l rm3l added this to the v3.13.0 🚀 milestone Jun 28, 2023
@odo-robot
Copy link

odo-robot bot commented Jun 28, 2023

Validate Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 28, 2023

Kubernetes Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 28, 2023

Windows Tests (OCP) on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 28, 2023

OpenShift Tests on commit finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 28, 2023

Kubernetes Docs Tests on commit f276d0d finished successfully.
View logs: TXT HTML

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 28, 2023
@feloy
Copy link
Contributor

feloy commented Jun 28, 2023

/override NoCluster-Integration-tests/NoCluster-Integration-tests

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Not related

@openshift-ci
Copy link

openshift-ci bot commented Jun 28, 2023

@feloy: Overrode contexts on behalf of feloy: NoCluster-Integration-tests/NoCluster-Integration-tests, OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:

/override NoCluster-Integration-tests/NoCluster-Integration-tests

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Not related

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit ce1d824 into redhat-developer:main Jun 28, 2023
@rm3l rm3l deleted the add-.gitattributes-to-customize-how-changed-files-appear-on-github branch June 28, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy feloy approved these changes

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees

@feloy feloy

Labels
kind/task Issue is actionable task lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
v3.13.0 🚀
Development

Successfully merging this pull request may close these issues.
3 participants
@rm3l @feloy @openshift-merge-robot