Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

odo init filters devfile stacks by supported architectures #7004

Merged
merged 10 commits into from
Aug 1, 2023
Merged

odo init filters devfile stacks by supported architectures #7004

merged 10 commits into from
Aug 1, 2023

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Jul 27, 2023

What type of PR is this:

/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6803

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Jul 27, 2023 •
edited by github-actions bot
Loading

🔨 Deploy Preview deleted from internal cluster!

Name Link
🔨 Latest commit 5d840ec
😎 Deploy Preview https://odo-dev-pr-7004.odo-test-kubernete-449701-49529fc6e6a4a9fe7ebba9a3db5b55c4-0000.eu-de.containers.appdomain.cloud/

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Jul 27, 2023
@feloy feloy requested a review from rm3l July 27, 2023 09:51
@openshift-ci openshift-ci bot requested a review from kadel July 27, 2023 09:51
@odo-robot
Copy link

odo-robot bot commented Jul 27, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit cab4313 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 27, 2023 •
edited
Loading

Unit Tests on commit cab4313 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 27, 2023 •
edited
Loading

Windows Tests (OCP) on commit cab4313 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 27, 2023 •
edited
Loading

Validate Tests on commit cab4313 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 27, 2023 •
edited
Loading

NoCluster Tests on commit cab4313 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 27, 2023 •
edited
Loading

Kubernetes Tests on commit cab4313 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 27, 2023 •
edited
Loading

OpenShift Tests on commit cab4313 finished successfully.
View logs: TXT HTML

@feloy feloy changed the title odo init filters devfile stacks by supported architectures [wip] odo init filters devfile stacks by supported architectures Jul 27, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jul 27, 2023
@odo-robot
Copy link

odo-robot bot commented Jul 28, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 3cb1f5c finished successfully.
View logs: TXT HTML

@feloy feloy temporarily deployed to internal July 28, 2023 08:38 — with GitHub Actions Inactive
@feloy feloy temporarily deployed to internal July 28, 2023 11:41 — with GitHub Actions Inactive
@feloy feloy closed this Jul 28, 2023
@feloy feloy reopened this Jul 28, 2023
@feloy feloy temporarily deployed to internal July 28, 2023 15:35 — with GitHub Actions Inactive
@feloy feloy temporarily deployed to internal July 31, 2023 08:13 — with GitHub Actions Inactive
@feloy feloy temporarily deployed to internal July 31, 2023 08:18 — with GitHub Actions Inactive
@feloy feloy temporarily deployed to internal July 31, 2023 10:33 — with GitHub Actions Inactive
@feloy feloy temporarily deployed to internal July 31, 2023 11:28 — with GitHub Actions Inactive
@feloy feloy changed the title [wip] odo init filters devfile stacks by supported architectures odo init filters devfile stacks by supported architectures Jul 31, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jul 31, 2023
rm3l
rm3l requested changes Aug 1, 2023
View reviewed changes
pkg/api/analyze.go Outdated Show resolved Hide resolved
pkg/odo/cli/registry/registry.go Outdated Show resolved Hide resolved
pkg/init/backend/interactive.go Show resolved Hide resolved
@feloy @rm3l
Update pkg/odo/cli/registry/registry.go
67e1555 
Co-authored-by: Armel Soro <armel@rm3l.org>
@feloy feloy temporarily deployed to internal August 1, 2023 09:47 — with GitHub Actions Inactive
@feloy feloy temporarily deployed to internal August 1, 2023 09:49 — with GitHub Actions Inactive
@feloy feloy requested a review from rm3l August 1, 2023 10:54
@feloy feloy temporarily deployed to internal August 1, 2023 12:02 — with GitHub Actions Inactive
@rm3l rm3l mentioned this pull request Jun 12, 2023
Closed
1 task
@feloy feloy temporarily deployed to internal August 1, 2023 14:01 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 1, 2023
@rm3l rm3l added area/registry Issues or PRs related to Devfile registries area/init Issues or PRs related to `odo init` labels Aug 1, 2023
@feloy
Copy link
Contributor Author

feloy commented Aug 1, 2023 

[FAILED] [2.933 seconds]
odo init interactive command tests label nocluster [It] should start downloading starter project only after all interactive questions have been asked [nocluster]

@feloy
Copy link
Contributor Author

feloy commented Aug 1, 2023

/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented Aug 1, 2023

@feloy: Overrode contexts on behalf of feloy: windows-integration-test/Windows-test

In response to this:

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit d41364e into redhat-developer:main Aug 1, 2023
24 checks passed
@openshift-merge-robot openshift-merge-robot temporarily deployed to internal August 1, 2023 17:36 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

Assignees

@rm3l rm3l

Labels
area/init Issues or PRs related to `odo init` area/registry Issues or PRs related to Devfile registries kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filtering devfile stacks based on the architecture field in metadata when running odo init
3 participants
@feloy @rm3l @openshift-merge-robot