-
Notifications
You must be signed in to change notification settings - Fork 91
Fix random e2e failure. #534
Fix random e2e failure. #534
Conversation
/retest |
1 similar comment
/retest |
/test e2e |
3 similar comments
/test e2e |
/test e2e |
/test e2e |
/retest |
/test e2e |
/test e2e |
/test 4.5-e2e |
/test lint |
/retest |
/test 4.5-e2e |
/test 4.5-e2e |
Tested this PR locally. E2E passes for me locally on 4.4 cluster. |
/lgtm |
/test 4.5-e2e |
/test e2e |
/test e2e |
@Avni-Sharma I just tested e2e locally on 4.5 cluster they passed.
Anc they passed on CI too. |
Thanks @pratikjagrut . I will try running |
Passes on a fresh cluster for me now. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes that need to be performed in this PR still since some functions have lost their purpose since part of their business logic has been modified as noted in all inspect
vs assert
comments.
/retest |
From the PR's description:
|
/retest |
/lgtm |
- Seed random with time.Now to generate unique digits on every subtest run. - Replace retry code block with require.Eventually(). - Update github.com/stretchr/testify from v1.4.0 to v1.6.1 The 1.4.0 version we were using had a bug in the Eventually function, which caused flaky results. - Increasing timeout for existing Eventually function. - Update vendor dependencies. - Updating test timeout. - Add --skip-cleanup-error=true flag.
I pushed squashed commit. |
Looks like the e2e tests failed for the infinite loop (#523) |
/retest |
@pmacik One reason I could think of is if we create SBR before the application and then the operator is watching for the application deployment to be ready, and at the same time |
Hi @pratikjagrut can you make an issue for the above-mentioned scenario so that we can look it up again. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: isutton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Motivation
fix E2E failure
Changes
Seed random with time.Now to generate unique digits on every subtest call.
Replace retry code block with require.Eventually.
Remove test timeout from makefile test-e2e target.
Update github.com/stretchr/testify from v1.4.0 to v1.6.1
The 1.4.0 version we were using had a bug in the Eventually function,
which caused flaky results.
Increasing timeout for Eventually function
Update vendor dependencies.
Updating test timeout.
Testing
make test-e2e