[WIP] Fix random e2e failures. (#534 follow-up) #539
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Followup on #534 |
pmacik
changed the title
|
/retest |
- Seed random with time.Now to generate unique digits on every subtest call. - Update github.com/stretchr/testify from v1.4.0 to v1.6.1 The 1.4.0 version we were using had a bug in the Eventually function, which caused flacky results. - Update vendored dependencies.
|
/retest |
|
@pmacik: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@pmacik: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Motivation
fix E2E failure
Changes
Seed random with time.Now to generate unique digits on every subtest call.
Update github.com/stretchr/testify from v1.4.0 to v1.6.1
The 1.4.0 version we were using had a bug in the Eventually function,
which caused flaky results.
Increasing timeout for Eventually function
Update vendored dependencies.
Testing
make test-e2e