Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sandbox: Verification code request form times out #2514

Closed
dgolovin opened this issue Aug 19, 2022 · 2 comments · Fixed by #2517
Closed

Sandbox: Verification code request form times out #2514

dgolovin opened this issue Aug 19, 2022 · 2 comments · Fixed by #2517
Labels
kind/bug priority/critical
Milestone
0.6.0

Comments

@dgolovin
Copy link
Collaborator

From @worldofgeese: Screen that request a SMS code sends the SMS code to phone number, however Connector never finishes request instead timing out.

Here is a GIF showing the flow with a fake number entered:

2022-08-19_10h27_09

#2474 (comment)
@dgolovin dgolovin mentioned this issue Aug 19, 2022
Closed
@dgolovin
Copy link
Collaborator Author

@vdemeester it seems there is a problem with parsing json response of request. I cannot figure out now, because number of requests is limited per day and I am out of limit till tomorrow.

@dgolovin dgolovin added this to the 0.6.0 milestone Aug 23, 2022
dgolovin added a commit to dgolovin/vscode-openshift-tools that referenced this issue Aug 23, 2022
@dgolovin
Do not parse response body in case OK status is true
51ba5ee 
This PR fixes redhat-developer#2514.

Signed-off-by: Denis Golovin dgolovin@redhat.com
@dgolovin dgolovin mentioned this issue Aug 23, 2022
Merged
@dgolovin
Copy link
Collaborator Author

@jeffmaury This error was introduced by 95f8697. Nothing changed on sanbox registration service side.

dgolovin added a commit that referenced this issue Aug 23, 2022
@dgolovin
Do not parse response body in case OK status is true
e5bf0df 
This PR fixes #2514.

Signed-off-by: Denis Golovin dgolovin@redhat.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug priority/critical
Projects
None yet
Milestone
0.6.0
Development

Successfully merging a pull request may close this issue.

Do not parse response body in case OK status is true dgolovin/vscode-openshift-tools
1 participant
@dgolovin