Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not parse response body in case OK status is true #2517

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

dgolovin
Copy link
Collaborator

This PR fixes #2514.

Signed-off-by: Denis Golovin dgolovin@redhat.com

This PR fixes redhat-developer#2514.

Signed-off-by: Denis Golovin dgolovin@redhat.com
@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #2517 (51ba5ee) into main (66232c4) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2517      +/-   ##
==========================================
- Coverage   67.17%   67.13%   -0.04%     
==========================================
  Files          55       55              
  Lines        3628     3630       +2     
  Branches      659      660       +1     
==========================================
  Hits         2437     2437              
- Misses       1191     1193       +2     
Impacted Files Coverage Δ
src/openshift/sandbox.ts 52.00% <0.00%> (-4.53%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dgolovin dgolovin merged commit e5bf0df into redhat-developer:main Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sandbox: Verification code request form times out
1 participant