Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate decreasing npm run compile times #2875

Closed
datho7561 opened this issue May 15, 2023 · 1 comment · Fixed by #2914
Closed

Investigate decreasing npm run compile times #2875

datho7561 opened this issue May 15, 2023 · 1 comment · Fixed by #2914
Assignees
@datho7561

Comments

@datho7561
Copy link
Contributor

Currently, running npm run compile takes a while (> 1 minute on my computer). This long build time even more noticeable when running the tests, since the script to run the tests always re-compiles/bundles the extension before running the tests. It would be nice to investigate ways to reduce this compile time to make it easier to develop the extension.

One option worth investigating is esbuild, which claims to be 100x faster than webpack
@datho7561
Copy link
Contributor Author

I'm interested in taking a look into this this sprint if I have time (I'll prioritize other issues first)

@datho7561 datho7561 mentioned this issue May 17, 2023
Closed
datho7561 added a commit to datho7561/vscode-openshift-tools that referenced this issue May 26, 2023
@datho7561
Switch from webpack to esbuild for bundling webviews
b00d4d9 
This PR uses esbuild instead of webpack to bundle the webviews.
This dramatically reduces the time it takes to bundle the webviews,
from >50 seconds to <1 second.

This PR also modifies the npm scripts and VS Code launch configurations
to always recompile the webviews before launching.

I also set up eslint to be run before launching the extension.
If the extension seems slower to launch in debug mode, this is why.

Closes redhat-developer#2875

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 mentioned this issue May 26, 2023
Merged
datho7561 added a commit to datho7561/vscode-openshift-tools that referenced this issue May 26, 2023
@datho7561
Switch from webpack to esbuild for bundling webviews
8297c8e 
This PR uses esbuild instead of webpack to bundle the webviews.
This dramatically reduces the time it takes to bundle the webviews,
from >50 seconds to <1 second.

This PR also modifies the npm scripts and VS Code launch configurations
to always recompile the webviews before launching.

I also set up eslint to be run before launching the extension.
If the extension seems slower to launch in debug mode, this is why.

Closes redhat-developer#2875

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-openshift-tools that referenced this issue May 29, 2023
@datho7561
Switch from webpack to esbuild for bundling webviews
6f2b9fb 
This PR uses esbuild instead of webpack to bundle the webviews.
This dramatically reduces the time it takes to bundle the webviews,
from >50 seconds to <1 second.

This PR also modifies the npm scripts and VS Code launch configurations
to always recompile the webviews before launching.

I also set up eslint to be run before launching the extension.
If the extension seems slower to launch in debug mode, this is why.

Closes redhat-developer#2875

Signed-off-by: David Thompson <davthomp@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@datho7561 datho7561

Labels
None yet
Projects
IDE Cloudaptors
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch from webpack to esbuild for bundling webviews datho7561/vscode-openshift-tools
1 participant
@datho7561