-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from webpack to esbuild for bundling webviews #2914
Switch from webpack to esbuild for bundling webviews #2914
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2914 +/- ##
==========================================
+ Coverage 36.78% 37.10% +0.31%
==========================================
Files 53 54 +1
Lines 3681 3652 -29
Branches 715 716 +1
==========================================
+ Hits 1354 1355 +1
+ Misses 2327 2297 -30
☔ View full report in Codecov by Sentry. |
I realized that type checking is not being performed on the webview files. I'm going to make a quick change to fix that. |
Just ran into this: microsoft/vscode#70283. Prelaunch tasks that use |
b00d4d9
to
8297c8e
Compare
Tried it out and seems to be working well for me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR uses esbuild instead of webpack to bundle the webviews. This dramatically reduces the time it takes to bundle the webviews, from >50 seconds to <1 second. This PR also modifies the npm scripts and VS Code launch configurations to always recompile the webviews before launching. I also set up eslint to be run before launching the extension. If the extension seems slower to launch in debug mode, this is why. Closes redhat-developer#2875 Signed-off-by: David Thompson <davthomp@redhat.com>
8297c8e
to
6f2b9fb
Compare
This PR uses esbuild instead of webpack to bundle the webviews. This dramatically reduces the time it takes to bundle the webviews, from >50 seconds to <1 second.
This PR also modifies the npm scripts and VS Code launch configurations to always recompile the webviews before launching.
I also set up eslint to be run before launching the extension. If the extension seems slower to launch in debug mode, this is why.
Closes #2875
Signed-off-by: David Thompson davthomp@redhat.com