Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension commands fail to run in vsix with "Error: Cannot find module '../build/bundle-tools'" #2948

Closed
datho7561 opened this issue Jun 6, 2023 · 0 comments · Fixed by #2950
Closed

Extension commands fail to run in vsix with "Error: Cannot find module '../build/bundle-tools'" #2948

datho7561 opened this issue Jun 6, 2023 · 0 comments · Fixed by #2950
Assignees
@datho7561
Milestone
1.5.0

Comments

@datho7561
Copy link
Contributor

"Error: Cannot find module '../build/bundle-tools'" is output in the extension host.

This happens, since we remove ./out/build/bundle-tools.js from the vsix using the .vscodeignore
@datho7561 datho7561 self-assigned this Jun 6, 2023
datho7561 added a commit to datho7561/vscode-openshift-tools that referenced this issue Jun 6, 2023
@datho7561
Move download scripts into ./src
06e2d5f 
- Also list packages that they require as runtime dependencies

Fixes redhat-developer#2948

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 mentioned this issue Jun 6, 2023
Merged
@mohitsuman mohitsuman added this to the 1.5.0 milestone Jun 7, 2023
mohitsuman pushed a commit that referenced this issue Jun 7, 2023
@datho7561 @msivasubramaniaan
Move download scripts into ./src (#2950)
fbacd3f 
* Move download scripts into ./src

- Also list packages that they require as runtime dependencies

Fixes #2948

Signed-off-by: David Thompson <davthomp@redhat.com>

* folder renamed

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>

* made correct reference of the file

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>

* made correct reference of the file

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>

---------

Signed-off-by: David Thompson <davthomp@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Co-authored-by: msivasubramaniaan <msivasub@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@datho7561 datho7561

Labels
None yet
Projects
IDE Cloudaptors
Archived in project
Milestone
1.5.0
Development

Successfully merging a pull request may close this issue.

Move download scripts into ./src datho7561/vscode-openshift-tools
2 participants
@mohitsuman @datho7561