-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move download scripts into ./src #2950
Move download scripts into ./src #2950
Conversation
- Also list packages that they require as runtime dependencies Fixes redhat-developer#2948 Signed-off-by: David Thompson <davthomp@redhat.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2950 +/- ##
==========================================
+ Coverage 37.36% 38.01% +0.65%
==========================================
Files 57 60 +3
Lines 3715 3809 +94
Branches 729 744 +15
==========================================
+ Hits 1388 1448 +60
- Misses 2327 2361 +34
☔ View full report in Codecov by Sentry. |
@datho7561 So with this PR, now the vsix files works properly with perfect tools installation ? |
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@datho7561 I have tested your PR and its working fine. Due to release thing I have renamed the folder and pushed the code to your branch |
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This is because we now use them when the extension is running for installing the tools into dev containers.
Also, list packages that the scripts require as runtime dependencies.
Fixes #2948
Signed-off-by: David Thompson davthomp@redhat.com