We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To reproduce:
expected: the "component name" field is populated with the folder name
actual: the "component name" is populated with the absolute path of the folder, using a Windows-style path (with drive letter and \)
\
The text was updated successfully, but these errors were encountered:
Fix suggest component name on Windows
fb3b43d
Fixes redhat-developer#3127 Signed-off-by: David Thompson <davidethompson@me.com>
Speaking of component name, could we try to sanitize the initial component name for git repo imports :
vscode-openshift-tools/src/webview/create-component/pages/fromExistingGitRepo.tsx
Line 415 in 843dca5
so that they respect
vscode-openshift-tools/src/webview/common-ext/createComponentHelpers.ts
Lines 95 to 99 in 843dca5
(eg. https://github.com/openshift-evangelists/Wild-West-Frontend fails validation )
Sorry, something went wrong.
0cc0fea
Fixes #3127 Signed-off-by: David Thompson <davidethompson@me.com>
datho7561
Successfully merging a pull request may close this issue.
To reproduce:
expected: the "component name" field is populated with the folder name
actual: the "component name" is populated with the absolute path of the folder, using a Windows-style path (with drive letter and
\
)The text was updated successfully, but these errors were encountered: