-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix suggest component name on Windows #3142
Fix suggest component name on Windows #3142
Conversation
Fixes redhat-developer#3127 Signed-off-by: David Thompson <davidethompson@me.com>
This requires Windows to test, since the bug only happens on Windows |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3142 +/- ##
=======================================
Coverage 31.99% 31.99%
=======================================
Files 74 74
Lines 5122 5122
Branches 974 974
=======================================
Hits 1639 1639
Misses 3483 3483 ☔ View full report in Codecov by Sentry. |
@msivasubramaniaan do you have time to review this today? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found an issue, Step to reproduce:
- Add Multiple projects(Without Dev file) into workspace.
- Right click the any of the projects other than the first one and click "Create Component from Folder"
Issue:
The create component page opened for the first project
Expected:
It should opened the selected project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mentioned issue on the comment
Yes, that is #3122. Do you mind if I create a separate PR for that? I'll try to get it done today |
I can't move it to the very top, but I can use the groups feature to put it higher up (right below "Paste" in your case). Does this sound good @msivasubramaniaan ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the review! |
Fixes #3127
Signed-off-by: David Thompson davidethompson@me.com