Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix suggest component name on Windows #3142

Merged

Conversation

datho7561
Copy link
Contributor

Fixes #3127

Signed-off-by: David Thompson davidethompson@me.com

Fixes redhat-developer#3127

Signed-off-by: David Thompson <davidethompson@me.com>
@datho7561
Copy link
Contributor Author

This requires Windows to test, since the bug only happens on Windows

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (bc5ad30) 31.99% compared to head (fb3b43d) 31.99%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3142   +/-   ##
=======================================
  Coverage   31.99%   31.99%           
=======================================
  Files          74       74           
  Lines        5122     5122           
  Branches      974      974           
=======================================
  Hits         1639     1639           
  Misses       3483     3483           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datho7561
Copy link
Contributor Author

@msivasubramaniaan do you have time to review this today?

@msivasubramaniaan
Copy link
Collaborator

It is working as expected.
image

But one suggestion that currently "Create Component from Folder" option was bottom of the menu. Will you make it to move on top?
image

Copy link
Collaborator

@msivasubramaniaan msivasubramaniaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found an issue, Step to reproduce:

  • Add Multiple projects(Without Dev file) into workspace.
  • Right click the any of the projects other than the first one and click "Create Component from Folder"

Issue:
The create component page opened for the first project

Expected:
It should opened the selected project.

issue-3127

Copy link
Collaborator

@msivasubramaniaan msivasubramaniaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioned issue on the comment

@datho7561
Copy link
Contributor Author

datho7561 commented Aug 31, 2023

Yes, that is #3122. Do you mind if I create a separate PR for that? I'll try to get it done today

@datho7561
Copy link
Contributor Author

@msivasubramaniaan see #3149

@datho7561
Copy link
Contributor Author

Will you make it to move on top?

I can't move it to the very top, but I can use the groups feature to put it higher up (right below "Paste" in your case). Does this sound good @msivasubramaniaan ?

Copy link
Collaborator

@msivasubramaniaan msivasubramaniaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datho7561
Copy link
Contributor Author

Thanks for the review!

@datho7561 datho7561 merged commit 0cc0fea into redhat-developer:main Aug 31, 2023
5 checks passed
@datho7561 datho7561 deleted the 3127-suggest-correct-name-windows branch August 31, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Component from Folder doesn't trim suggested name to last portion of the path on Windows
2 participants