Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct folder during create component context menu button #3149

Conversation

datho7561
Copy link
Contributor

Use the selected folder when activating create component through the context menu instead of always using the first workspace folder.

Fixes #3122

Signed-off-by: David Thompson davthomp@redhat.com

Use the selected folder when activating create component through the
context menu instead of always using the first workspace folder.

Fixes redhat-developer#3122

Signed-off-by: David Thompson <davthomp@redhat.com>
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 33.33% and no project coverage change.

Comparison is base (843dca5) 32.97% compared to head (5bbd01c) 32.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3149   +/-   ##
=======================================
  Coverage   32.97%   32.97%           
=======================================
  Files          75       75           
  Lines        5244     5244           
  Branches      996      996           
=======================================
  Hits         1729     1729           
  Misses       3515     3515           
Files Changed Coverage Δ
src/openshift/component.ts 26.79% <33.33%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@msivasubramaniaan msivasubramaniaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msivasubramaniaan msivasubramaniaan merged commit 1d65651 into redhat-developer:main Aug 31, 2023
5 checks passed
@datho7561 datho7561 deleted the 3122-create-component-uses-first-folder branch August 31, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Component From Folder always uses first open folder, regardless of which one was right clicked on
2 participants