Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component create from Git fails if a devfile exists in git repo #3386

Closed
vrubezhny opened this issue Oct 2, 2023 · 0 comments · Fixed by #3387
Closed

Component create from Git fails if a devfile exists in git repo #3386

vrubezhny opened this issue Oct 2, 2023 · 0 comments · Fixed by #3387
Assignees
Labels
Milestone

Comments

@vrubezhny
Copy link
Contributor

vrubezhny commented Oct 2, 2023

Create Component view cannot be opened when creating a new component from a git, using https://github.com/openshift-evangelists/Wild-West-Frontend app repo:

Uncaught TypeError: Cannot read properties of undefined (reading 'port')
    at SetNameAndFolder (index.js:131409:73)
    at renderWithHooks (index.js:13229:28)
    at mountIndeterminateComponent (index.js:15405:23)
    at beginWork (index.js:16234:24)
    at HTMLUnknownElement.callCallback2 (index.js:5636:24)
    at Object.invokeGuardedCallbackDev (index.js:5661:26)
    at invokeGuardedCallback (index.js:5695:41)
    at beginWork$1 (index.js:19395:17)
    at performUnitOfWork (index.js:18621:23)
    at workLoopSync (index.js:18572:15)
index.js:16871 The above error occurred in the <SetNameAndFolder> component:

    at SetNameAndFolder (https://file+.vscode-resource.vscode-cdn.net/home/jeremy/projects/vscode-openshift-tools/source/vscode-openshift-tools/out/createComponentViewer/index.js:131408:71)
    at FromExistingGitRepo (https://file+.vscode-resource.vscode-cdn.net/home/jeremy/projects/vscode-openshift-tools/source/vscode-openshift-tools/out/createComponentViewer/index.js:131795:34)
    at div

Which maps to line 39 at

const [portNumber, setPortNumber] = React.useState<number>(props.devfile.port);

vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Oct 2, 2023
@vrubezhny vrubezhny changed the title Component create from Git fails if port is not defined in devfile Component create from Git fails if a devfile exists in git repo Oct 2, 2023
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Oct 2, 2023
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Oct 3, 2023
@vrubezhny vrubezhny self-assigned this Oct 3, 2023
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Oct 9, 2023
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Oct 10, 2023
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Oct 10, 2023
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Oct 10, 2023
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Oct 11, 2023
@datho7561 datho7561 added this to the 1.10.0 milestone Oct 11, 2023
datho7561 pushed a commit that referenced this issue Oct 11, 2023
Fixes: #3386

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
2 participants