-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component create from Git fails if a devfile exists in git repo #3386 #3387
Component create from Git fails if a devfile exists in git repo #3386 #3387
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3387 +/- ##
==========================================
- Coverage 36.09% 35.76% -0.34%
==========================================
Files 78 78
Lines 5446 5502 +56
Branches 1067 1082 +15
==========================================
+ Hits 1966 1968 +2
- Misses 3480 3534 +54
☔ View full report in Codecov by Sentry. |
f94347b
to
7269032
Compare
f18c0f7
to
aca679b
Compare
aca679b
to
1827f46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the comment I added, it would be nice to populate the "Component Name" field with the component name from the existing Devfile instead of the one that we generate.
1827f46
to
e98fb34
Compare
@datho7561 Do you mean we should get the devfile's Doesn't look good, IMHO, because we're losing the Git-repo name, previously used to be an initial component name if we change it this way, f.i:
I'd say using the Git-repo URL/Path to construct the initial component name better answers the question like "What this component is?" |
I think in the case of Wild-West-Frontend (i.e. when importing a git repo or local codebase with an existing Devfile), it makes sense to populate the field with the name from the existing Devfile, since if its already set, the user probably doesn't want to change it, even if it's different from the repo name. |
…t-developer#3386 Fixes: redhat-developer#3386 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
e98fb34
to
04e273e
Compare
@datho7561 Resonably. I've updated the form so the initial component name is taken from a devfile provided |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks, Victor!
Fixes: #3386