Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "Open Kuberbetes YAML file" to avoid accidental opens and duplicate files #3919

Closed
datho7561 opened this issue Feb 20, 2024 · 2 comments · Fixed by #3961
Closed

Improve "Open Kuberbetes YAML file" to avoid accidental opens and duplicate files #3919

datho7561 opened this issue Feb 20, 2024 · 2 comments · Fixed by #3961
Assignees
Labels
Milestone

Comments

@datho7561
Copy link
Contributor

From @vrubezhny :

When having a pod running, if you click on it's tree item once it opens its yaml file... Do you think it's a good thing?
I really don't like it as it opens this file in a new editor every time I eventually click on such a tree item...
Why don't we:

  1. open it by double click (instead of single click)?
  2. reuse the same editor for it? (probably it's difficult, but I believe it's possible)
@datho7561
Copy link
Contributor Author

I think that 1. might not be possible, but 2. is possible.

I think we might rely on vscode-kubernetes to provide this functionality. If so, we should also rewrite the code so that we don't depend on vscode-kubernetes.

@vrubezhny vrubezhny self-assigned this Feb 21, 2024
@vrubezhny
Copy link
Contributor

I just checked - the opening a Deployment YAML by single click is following the VSCode preferences:

image

... so users are able to configure VSCode to use single or double click to open a tree node (Deployment YAML in our case). As such no any fix is needed for №1.

vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Mar 5, 2024
…licate files redhat-developer#3919

Fixes: redhat-developer#3919

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Mar 5, 2024
…licate files redhat-developer#3919

Fixes: redhat-developer#3919

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Mar 6, 2024
…licate files redhat-developer#3919

Fixes: redhat-developer#3919

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
@datho7561 datho7561 added this to the 1.13.0 milestone Mar 6, 2024
datho7561 pushed a commit that referenced this issue Mar 6, 2024
…licate files #3919

Fixes: #3919

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
lgrossma pushed a commit to lgrossma/vscode-openshift-tools that referenced this issue Mar 7, 2024
…licate files redhat-developer#3919

Fixes: redhat-developer#3919

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
2 participants