Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "Open Kuberbetes YAML file" to avoid accidental opens and dup… #3961

Conversation

vrubezhny
Copy link
Contributor

…licate files #3919

Fixes: #3919

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 45.18%. Comparing base (da60441) to head (2cef3bc).
Report is 90 commits behind head on main.

Files Patch % Lines
src/explorer.ts 25.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3961       +/-   ##
===========================================
+ Coverage   32.37%   45.18%   +12.81%     
===========================================
  Files          85       85               
  Lines        6505     6670      +165     
  Branches     1349     1388       +39     
===========================================
+ Hits         2106     3014      +908     
+ Misses       4399     3656      -743     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vrubezhny vrubezhny requested a review from datho7561 March 5, 2024 17:45
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to working well! I had a few questions/comments about the regex being used

src/explorer.ts Outdated Show resolved Hide resolved
…licate files redhat-developer#3919

Fixes: redhat-developer#3919

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
@vrubezhny vrubezhny force-pushed the fix-prevent-openning-duplicate-deployment-files branch from 12e0289 to 2cef3bc Compare March 6, 2024 12:23
@vrubezhny vrubezhny requested a review from datho7561 March 6, 2024 12:32
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works for me. Thanks, Victor!

@datho7561 datho7561 merged commit a984c04 into redhat-developer:main Mar 6, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve "Open Kuberbetes YAML file" to avoid accidental opens and duplicate files
2 participants