-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not call getAllComponents() in activate #3880
Do not call getAllComponents() in activate #3880
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3880 +/- ##
===========================================
+ Coverage 32.37% 45.40% +13.03%
===========================================
Files 85 85
Lines 6505 6488 -17
Branches 1349 1342 -7
===========================================
+ Hits 2106 2946 +840
+ Misses 4399 3542 -857 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9ae98bd
to
7b19597
Compare
Part of redhat-developer#3850 Signed-off-by: David Thompson <davthomp@redhat.com>
7b19597
to
09c4ab5
Compare
Good catch! I fixed this issue, and refactored the code related to collecting the list of Devfiles. |
Serverless function tests are failing for me. The root causes could be that something is preventing the refresh button from being pressed, or that VS Code reports it has run out of filesystem watchers during the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - Devfile Registry editing works fine and GH Actions tests are passed.
Thanks!
Part of #3850
Signed-off-by: David Thompson davthomp@redhat.com