Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Operator-SDK 1.34.1 bumping OLM and K8s versions #1139

Conversation

tkrishtop
Copy link
Contributor

No description provided.

Signed-off-by: Tatiana Krishtop <tkrishto@redhat.com>
@tkrishtop tkrishtop marked this pull request as draft April 8, 2024 12:53
@openshift-ci openshift-ci bot requested review from bcrochet and jomkz April 8, 2024 12:53
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 8, 2024
Copy link

openshift-ci bot commented Apr 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tkrishtop
Once this PR has been reviewed and has the lgtm label, please assign jomkz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 8, 2024
Copy link

openshift-ci bot commented Apr 8, 2024

Hi @tkrishtop. Thanks for your PR.

I'm waiting for a redhat-openshift-ecosystem member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcibot
Copy link

dcibot commented Apr 8, 2024

@acornett21
Copy link
Contributor

@tkrishtop Thanks for the PR, but due to all of the issues in 1.34.0/1.34.1 I have zero desire to move to this version in preflight.

@dcibot
Copy link

dcibot commented Apr 10, 2024

Starting dci-check-change job.

@dcibot
Copy link

dcibot commented Apr 10, 2024

@dcibot
Copy link

dcibot commented Apr 11, 2024

  • dci-check-change no check (not a code change)

@dcibot
Copy link

dcibot commented Apr 11, 2024

Starting dci-check-change job.

@dcibot
Copy link

dcibot commented Apr 11, 2024

@acornett21
Copy link
Contributor

going to close this and raise a pr for 1.35.0 which is known to work.

@acornett21 acornett21 closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants