Fixed "Pyxis rejects test library development version numbers" #254
Conversation
|
Starting dci-check-change job. |
|
|
check workload preflight-green |
|
from change #254: |
| @@ -8,10 +8,9 @@ | |||
| preflight_output: "{{ lookup('file', preflight_results_file) | from_json }}" | |||
| preflight_artifact: "{{ lookup('file', preflight_log_file) | to_json }}" | |||
| pyxis_apikey: "{{ lookup('file', pyxis_apikey_path) }}" | |||
| preflight_release: "{{ preflight_output.test_library.version.split('+')[0] }}" | |||
There was a problem hiding this comment.
From the last failure I believe we need to define preflight_release: fact separately after this task or maybe move the fact preflight_output: as a var in this task?
| @@ -8,10 +8,9 @@ | |||
| preflight_output: "{{ lookup('file', preflight_results_file) | from_json }}" | |||
| preflight_artifact: "{{ lookup('file', preflight_log_file) | to_json }}" | |||
| pyxis_apikey: "{{ lookup('file', pyxis_apikey_path) }}" | |||
| preflight_release: "{{ preflight_output.test_library.version.split('+')[0] }}" | |||
There was a problem hiding this comment.
- name: Retrieve results of the preflight tests
vars:
preflight_prefix: "preflight_operator_{{ operator.name }}"
preflight_results_file: "{{ job_logs.path }}/{{ preflight_prefix }}_results.json"
preflight_log_file: "{{ job_logs.path }}/{{ preflight_prefix }}_preflight.log"
set_fact:
preflight_output: "{{ lookup('file', preflight_results_file) | from_json }}"
preflight_artifact: "{{ lookup('file', preflight_log_file) | to_json }}"
pyxis_apikey: "{{ lookup('file', pyxis_apikey_path) }}"
- name: Set preflight release
set_fact:
preflight_release: "{{ preflight_output.test_library.version.split('+')[0] }}"
|
also, let's change the galaxy.yml and .spec by bumping the minor version in-there |
nsilla
force-pushed
the
preflight_dev_version
branch
from
e3d82f7
to
296b936
Compare
|
|
Build succeeded. ✔️ dci-rpm-build-el8 SUCCESS in 3m 14s |
|
check workload preflight-green |
|
from change #254: |
There was a problem hiding this comment.
The tests are green, thanks @nsilla ! Let's also bump the collection version.
nsilla
force-pushed
the
preflight_dev_version
branch
from
296b936
to
2577ce9
Compare
Done. Have another job running to have all green. |
|
Starting dci-check-change job. |
|
Build succeeded. ✔️ dci-rpm-build-el8 SUCCESS in 3m 15s |
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
CheckDallasWorkload: preflight-green
The Pyxis API currently only supports the test library version 1.9.1 and rejects any development version based on that one (for instance, 1.9.1+abcdef0123456789).
We had a partial fix that would replace the test library commit ID in the pushed test results, but it left the version number unaltered, thus causing the Pyxis API to reject the requests.
This fix overrides the version number (if needed) along with the commit ID in the test results data.
build-depends: redhat-openshift-ecosystem/openshift-preflight#1139