Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use constructor-style for NoopSubmitter #810

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Use constructor-style for NoopSubmitter #810

merged 1 commit into from
Oct 27, 2022

Conversation

sebrandon1
Copy link
Contributor

Inspired by #809

This change can be separated from the rest of the lib work, but using a constructor-style to creating the noopSubmitter objects.

@openshift-ci openshift-ci bot requested review from jomkz and komish October 24, 2022 19:38
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 24, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 24, 2022

Hi @sebrandon1. Thanks for your PR.

I'm waiting for a redhat-openshift-ecosystem member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcibot
Copy link

dcibot commented Oct 24, 2022

@acornett21
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 24, 2022
@acornett21
Copy link
Contributor

I don't think the linter will allow us to switch to this style of coding since for current use cases we are never setting a reason, meaning the linter wants us to remove that parameters from the method signature completely.

@sebrandon1 sebrandon1 force-pushed the constructor_style_noop_submitter branch from a28821c to efeb8c3 Compare October 25, 2022 16:35
@coveralls
Copy link

coveralls commented Oct 25, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.004%) to 84.476% when pulling 4a07af1 on sebrandon1:constructor_style_noop_submitter into 7a7320f on redhat-openshift-ecosystem:main.

acornett21
acornett21 reviewed Oct 25, 2022
View reviewed changes
cmd/types.go Outdated Show resolved Hide resolved
@dcibot
Copy link

dcibot commented Oct 25, 2022

@sebrandon1 sebrandon1 force-pushed the constructor_style_noop_submitter branch from efeb8c3 to b180830 Compare October 25, 2022 18:32
@dcibot
Copy link

dcibot commented Oct 25, 2022

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 26, 2022
@dcibot
Copy link

dcibot commented Oct 26, 2022

error in check dallas: unable to rebase PR 810 from redhat-openshift-ecosystem/openshift-preflight branch main

@tkrishtop
Copy link
Contributor

hi @sebrandon1, sorry for the failed job, we got an issue with the folder permissions in Dallas, but it is now fixed. Everything should work once your branch is rebased.

@sebrandon1 sebrandon1 force-pushed the constructor_style_noop_submitter branch from b180830 to 4a07af1 Compare October 26, 2022 14:10
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 26, 2022
@sebrandon1
Copy link
Contributor Author

Fully rebased on top of the lib changes from yesterday. Thanks for the reviews!

@dcibot
Copy link

dcibot commented Oct 26, 2022

bcrochet
bcrochet approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@bcrochet bcrochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 27, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, bcrochet, sebrandon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [acornett21,bcrochet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acornett21 acornett21 merged commit 024e916 into redhat-openshift-ecosystem:main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcrochet bcrochet bcrochet approved these changes

@acornett21 acornett21 acornett21 approved these changes

@jomkz jomkz Awaiting requested review from jomkz

@komish komish Awaiting requested review from komish

Assignees

@bcrochet bcrochet

@acornett21 acornett21

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sebrandon1 @dcibot @acornett21 @coveralls @tkrishtop @bcrochet @openshift-merge-robot