-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grab the image that matches the arch of the binary #821
Conversation
Crane defaults to "linux/amd64" as the platform, unless an option is passed with WithPlatform. This defaults to an OS of "linux", and an architecture of runtime.GOARCH, which is basically set at build time. Additional work will be required to process all arches of an image in one go. Related redhat-openshift-ecosystem#807 Signed-off-by: Brad P. Crochet <brad@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@skattoju4: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acornett21, bcrochet, skattoju, skattoju4 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Crane defaults to "linux/amd64" as the platform, unless an option is passed with WithPlatform. This defaults to an OS of "linux", and an architecture of runtime.GOARCH, which is basically set at build time.
Additional work will be required to process all arches of an image in one go.
Related #807
Signed-off-by: Brad P. Crochet brad@redhat.com