-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support manifest list #807
Comments
Hi @lucacome preflight uses a library Currently, the workaround is what you mentioned, to certify every architecture individually on the appropriate base system. With that said, multi-arch/manifest list is something that has been talked about being added to the container certification process. I'm not sure what the priority of that is, but it would not be just a change in preflight, backend systems at Red Hat would also need to be changed as well. |
Hi @acornett21 thanks for the response and the explanation.
It seemed to default to
For the latest round of certifications I was able to do everything from one system, just specifying different SHAs...I hope everything worked 😅
Is there a better place for me to open an issue to ask for the backend systems to support this? |
If you are on an For your other questions I've messaged you on slack. |
Sorry I forgot to mention that I'm on Thanks! |
I just tried on arm64, and you are correct. It pulled the amd64 image. I'll take a look at why that's happening. |
Crane defaults to "linux/amd64" as the platform, unless an option is passed with WithPlatform. This defaults to an OS of "linux", and an architecture of runtime.GOARCH, which is basically set at build time. Additional work will be required to process all arches of an image in one go. Fixes redhat-openshift-ecosystem#807 Signed-off-by: Brad P. Crochet <brad@redhat.com>
Crane defaults to "linux/amd64" as the platform, unless an option is passed with WithPlatform. This defaults to an OS of "linux", and an architecture of runtime.GOARCH, which is basically set at build time. Additional work will be required to process all arches of an image in one go. Related redhat-openshift-ecosystem#807 Signed-off-by: Brad P. Crochet <brad@redhat.com>
Crane defaults to "linux/amd64" as the platform, unless an option is passed with WithPlatform. This defaults to an OS of "linux", and an architecture of runtime.GOARCH, which is basically set at build time. Additional work will be required to process all arches of an image in one go. Related #807 Signed-off-by: Brad P. Crochet <brad@redhat.com>
Without any changes in the backend systems, This will definitely improve the certification process, at least while we wait for manifest list support on the backend. |
If a multiarch manifest is supplied to check container, it would default to the platform preflight is running on. This --platform flag allows the user to choose with platform image to use, without having to resort to using SHA digests. Fixes redhat-openshift-ecosystem#807 Signed-off-by: Brad P. Crochet <brad@redhat.com>
If a multiarch manifest is supplied to check container, it would default to the platform preflight is running on. This --platform flag allows the user to choose with platform image to use, without having to resort to using SHA digests. Fixes redhat-openshift-ecosystem#807 Signed-off-by: Brad P. Crochet <brad@redhat.com>
If a multiarch manifest is supplied to check container, it would default to the platform preflight is running on. This --platform flag allows the user to choose with platform image to use, without having to resort to using SHA digests. Fixes #807 Signed-off-by: Brad P. Crochet <brad@redhat.com>
Hi everyone! I'm pinging here because with the latest version 1.5.0 the preflight still picking up only amd64 as architecture and it's not using the one the one that we pass in the I think that as @lucacome mentioned, preflight should detect the manifest and simply certify all the architectures inside, it's this even an option? Regards, |
@sxd Sorry for this miss on our part. We have fixed the issue and cut a new release. |
Hi @acornett21 Thank you!! everything it's working as expected now =) Cheers! |
Is your feature request related to a problem? Please describe.
I want to run
preflight check container
once for my multi-arch manifestDescribe the solution you'd like.
preflight
certifies all the images in a manifest list.Describe alternatives you've considered.
Manually certifying every architecture
Additional context.
Maybe I'm missing a flag or something? It seems like
preflight
is able to read the manifest list but defaults to using the image foramd64
.The text was updated successfully, but these errors were encountered: