-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding platform option to generateContainerCheckOptions #876
adding platform option to generateContainerCheckOptions #876
Conversation
Signed-off-by: Adam D. Cornett <adc@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@sebrandon1: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⤿ preflight check container --platform arm64 quay.io/opdev/preflight:stable
time="2023-01-27T10:41:53-06:00" level=info msg="certification library version" version="0.0.0 <commit: dd634ab32dd41d1c282f6df8730c20d5d040b63b>"
... extra logs redacted ...
time="2023-01-27T10:42:18-06:00" level=info msg="This image's tag stable will be paired with digest sha256:d63ebb9a3a9ea6970a9a7a2968eeebbd1cdc80ca9ef5a2b747758f09f25b3f53once this image has been published in accordance with Red Hat Certification policy. You may then
add or remove any supplemental tags through your Red Hat Connect portal as you see fit.
... results and extra lines redacted ...
⤿ skopeo inspect --raw docker://quay.io/opdev/preflight:stable | jq .manifests[2]
{
"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
"size": 596,
"digest": "sha256:d63ebb9a3a9ea6970a9a7a2968eeebbd1cdc80ca9ef5a2b747758f09f25b3f53",
"platform": {
"architecture": "arm64",
"os": "linux"
}
}
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acornett21, komish, sebrandon1, skattoju The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When we refactored for
/lib
it seems--platform
was missed as an option to be passed through tocheck container
. This adds theplatoform
option to the check.-Relates: #807
Test Data
Input
Output
cert-image.json
fileSigned-off-by: Adam D. Cornett adc@redhat.com