Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding platform option to generateContainerCheckOptions #876

Merged
merged 1 commit into from
Jan 27, 2023
Merged

adding platform option to generateContainerCheckOptions #876

merged 1 commit into from
Jan 27, 2023

Conversation

acornett21
Copy link
Contributor

When we refactored for /lib it seems --platform was missed as an option to be passed through to check container. This adds the platoform option to the check.

-Relates: #807

Test Data

Input

check
container
quay.io/opdev/preflight:1.5.0
--submit
--pyxis-api-token=super-legit-token
--certification-project-id=62475e954a0f4241da0984f8
--platform=arm64

Output cert-image.json file

{
    "certified": false,
    "deleted": false,
    "docker_image_digest": "sha256:d63ebb9a3a9ea6970a9a7a2968eeebbd1cdc80ca9ef5a2b747758f09f25b3f53",
    "docker_image_id": "sha256:da0991f2444cb9924df895d267ae4cbb359eca735c143255e8b0b3c2a656b5b2",
    "image_id": "sha256:d63ebb9a3a9ea6970a9a7a2968eeebbd1cdc80ca9ef5a2b747758f09f25b3f53",
    "parsed_data": {
        "architecture": "arm64",
        "command": "--help",
        "created": "2023-01-19 22:33:14.050783235 +0000 UTC",
        "image_id": "sha256:d63ebb9a3a9ea6970a9a7a2968eeebbd1cdc80ca9ef5a2b747758f09f25b3f53",
...

Signed-off-by: Adam D. Cornett adc@redhat.com

Signed-off-by: Adam D. Cornett <adc@redhat.com>
@openshift-ci openshift-ci bot requested review from jomkz and skattoju January 27, 2023 16:21
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2023
Copy link
Contributor

@skattoju skattoju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2023
@coveralls
Copy link

Coverage Status

Coverage: 81.809% (-0.02%) from 81.826% when pulling dd634ab on acornett21:fix_platform_flag into 9e2b88b on redhat-openshift-ecosystem:main.

@openshift-ci
Copy link

openshift-ci bot commented Jan 27, 2023

@sebrandon1: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 ⤿ preflight check container --platform arm64 quay.io/opdev/preflight:stable
time="2023-01-27T10:41:53-06:00" level=info msg="certification library version" version="0.0.0 <commit: dd634ab32dd41d1c282f6df8730c20d5d040b63b>"

... extra logs redacted ...

time="2023-01-27T10:42:18-06:00" level=info msg="This image's tag stable will be paired with digest sha256:d63ebb9a3a9ea6970a9a7a2968eeebbd1cdc80ca9ef5a2b747758f09f25b3f53once this image has been published in accordance with Red Hat Certification policy. You may then
 add or remove any supplemental tags through your Red Hat Connect portal as you see fit.

... results and extra lines redacted ...
 ⤿ skopeo inspect --raw docker://quay.io/opdev/preflight:stable | jq .manifests[2]
{
  "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
  "size": 596,
  "digest": "sha256:d63ebb9a3a9ea6970a9a7a2968eeebbd1cdc80ca9ef5a2b747758f09f25b3f53",
  "platform": {
    "architecture": "arm64",
    "os": "linux"
  }
}

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jan 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, komish, sebrandon1, skattoju

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [acornett21,komish,skattoju]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acornett21 acornett21 merged commit 14e60b8 into redhat-openshift-ecosystem:main Jan 27, 2023
@acornett21 acornett21 deleted the fix_platform_flag branch January 27, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants