Add the ability to check a container from another platform #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
acornett21
reviewed
Nov 10, 2022
| @@ -47,6 +48,9 @@ func checkContainerCmd() *cobra.Command { | |||
| "URL paramater. This value may differ from the PID on the overview page. (env: PFLT_CERTIFICATION_PROJECT_ID)")) | |||
| _ = viper.BindPFlag("certification_project_id", checkContainerCmd.Flags().Lookup("certification-project-id")) | |||
|
|
|||
| checkContainerCmd.Flags().String("platform", rt.GOARCH, "Architecture of image to pull. Defaults to current platform.") | |||
There was a problem hiding this comment.
This is a nice way to default!
If a multiarch manifest is supplied to check container, it would default to the platform preflight is running on. This --platform flag allows the user to choose with platform image to use, without having to resort to using SHA digests. Fixes redhat-openshift-ecosystem#807 Signed-off-by: Brad P. Crochet <brad@redhat.com>
acornett21
approved these changes
Nov 10, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acornett21, bcrochet, komish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a multiarch manifest is supplied to check container, it would default to the platform preflight is running on. This --platform flag allows the user to choose with platform image to use, without having to resort to using SHA digests.
Fixes #807
Signed-off-by: Brad P. Crochet brad@redhat.com