Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support intermediate sync() calls in multi node pipelines #3226

Merged
merged 3 commits into from
Dec 13, 2022

Conversation

sazzad16
Copy link
Collaborator

@sazzad16 sazzad16 commented Dec 7, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2022

Codecov Report

Base: 66.96% // Head: 66.91% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (b83ca1f) compared to base (86d800a).
Patch coverage: 39.39% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3226      +/-   ##
============================================
- Coverage     66.96%   66.91%   -0.05%     
- Complexity     4606     4607       +1     
============================================
  Files           251      252       +1     
  Lines         14864    14880      +16     
  Branches        922      922              
============================================
+ Hits           9953     9957       +4     
- Misses         4511     4524      +13     
+ Partials        400      399       -1     
Impacted Files Coverage Δ
...redis/clients/jedis/params/ModuleLoadExParams.java 0.00% <0.00%> (ø)
src/main/java/redis/clients/jedis/Jedis.java 84.83% <57.14%> (-0.17%) ⬇️
...ava/redis/clients/jedis/MultiNodePipelineBase.java 21.13% <80.00%> (-0.32%) ⬇️
src/main/java/redis/clients/jedis/Protocol.java 90.62% <100.00%> (ø)
...ava/redis/clients/jedis/JedisClusterInfoCache.java 72.50% <0.00%> (+1.25%) ⬆️
src/main/java/redis/clients/jedis/JedisPubSub.java 71.81% <0.00%> (+1.81%) ⬆️
...nts/jedis/providers/ClusterConnectionProvider.java 78.57% <0.00%> (+5.35%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yangbodong22011
Copy link
Collaborator

@sazzad16 Pipelines have always been temporary and one-shot, are we sure we want to change this default behavior?

@sazzad16
Copy link
Collaborator Author

Pipelines have always been temporary and one-shot, are we sure we want to change this default behavior?

@yangbodong22011 It is possible in classic (single connection) pipeline. So it's not exactly the default behavior.

Also, if it is really one-shot, we don't need separate sync() and close(). Perhaps that's a question we should discuss?

@yangbodong22011
Copy link
Collaborator

It is possible in classic (single connection) pipeline. So it's not exactly the default behavior.

@sazzad16 yes, my mistake.

@sazzad16 sazzad16 merged commit 130d4f5 into redis:master Dec 13, 2022
@sazzad16 sazzad16 deleted the sync-sync branch December 13, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support intermediate sync() calls in multi node pipelines
4 participants