Client Side Caching: Alpha support #3038

dvora-h · 2023-11-13T01:02:56Z

Pull Request check-list

Please make sure to review and check all of these items:

Do tests and lints pass with this change?
Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
Is the new or changed code fully tested?
Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
Is there an example added to the examples folder (if applicable)?
Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

redis/cache.py

redis/client.py

redis/utils.py

redis/cache.py

chayim

@dvora-h see comments

codecov-commenter · 2023-11-15T23:45:15Z

Codecov Report

Attention: 63 lines in your changes are missing coverage. Please review.

Comparison is base (0113034) 91.33% compared to head (63bb591) 91.16%.

Files	Patch %	Lines
redis/cache.py	36.14%	53 Missing ⚠️
redis/client.py	69.69%	10 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3038      +/-   ##
==========================================
- Coverage   91.33%   91.16%   -0.18%     
==========================================
  Files         126      127       +1     
  Lines       32719    32846     +127     
==========================================
+ Hits        29884    29943      +59     
- Misses       2835     2903      +68

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

chayim · 2023-11-16T07:53:03Z

redis/asyncio/client.py

@@ -597,6 +597,7 @@ async def _disconnect_raise(self, conn: Connection, error: Exception):
    async def execute_command(self, *args, **options):
        """Execute a command and return a parsed response"""
        await self.initialize()
+        options.pop("keys", None)  # the keys is used only for client side caching


"the keys are used only for client side caching (thoughout this PR)

chayim · 2023-11-16T07:53:38Z

redis/cache.py

@@ -0,0 +1,326 @@
+import random


To keep in theme we discussed, maybe this should be redis.cache.LocalCache?

chayim · 2023-11-16T07:53:46Z

redis/cache.py

+_ACCESS_COUNT = "access_count"
+
+
+class EvictionPolicy(Enum):


chayim

One question, one change - change is only for comments

rueian · 2023-11-16T15:56:04Z

Wow, this is cool. Will the client tracking be supported in this client cache?

dvora-h · 2023-11-16T17:08:20Z

@rueian Yes, we are going to add it, this is why it's just an alpha version now I hope the next version will come soon with client tracking

rueian · 2023-11-17T00:25:06Z

@rueian Yes, we are going to add it, this is why it's just an alpha version now I hope the next version will come soon with client tracking

Great! Can’t wait to see this powerful feature be available on redis py. This will definitely gain more acknowledgment on this feature from more developers.

CSC

cd27dc3

dvora-h added feature New feature experimental labels Nov 13, 2023

dvora-h requested a review from chayim November 13, 2023 01:02

get keys from command

6c69ac4

chayim changed the title ~~Client Side Caching~~ Client Side Caching: Alpha support Nov 14, 2023