-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VoyageAI vectorizer and reranker #152
Conversation
VoyageAI vectorizer and reranker
VoyageAI vectorizer and reranker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tylerhutcherson LGTM!
@fzowl there are tests failing in our test matrix, can you address them before the branch goes stale? |
@bsbodden The failed tests seem to be related to GCP credentials, not during the code tests but during the Authenticate to GCP step, which is in your control, I believe. Can you please help me out with what the issue could be here? |
Will take a look and see if we can get this wrapped up, thanks team! |
Reformatting Adding VoyageAI to enum
@tylerhutcherson Thank you! |
@tylerhutcherson Any progress on this? Is there anything i can help? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it's great -- just a few things I caught when reviewing. I will get an API key today to set up in our CI. Also looks like there is an issue with the lockfile:
https://github.com/redis/redis-vl-python/actions/runs/10885688987/job/30434690376?pr=152
@tylerhutcherson Thank you very much! I was struggling a bit with the lockfile, i tried to update it but it was hanging every time for me. Thank you very much for your help! |
No problem! We're happy to support more integrations, and sorry this took so long. We just had a slew of customer requests we needed to focus on first. @fzowl I will close this PR in favor of the other, and plan to release soon. Will VoyageAI do any kind of announcement about the new integration or maybe host an example in your docs? That would be rad. |
@tylerhutcherson Yes, i will add RedisVL to our integrations in our site. |
No description provided.