-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate VoyageAI Vectorizer and Reranker class #223
Conversation
@tylerhutcherson Thank you very much! Please let me know if i can help you with this. |
@tylerhutcherson It seems like there is an error in the rerank code, i suggested a change: https://github.com/redis/redis-vl-python/pull/223/files#r1777636350 |
@fzowl We are so close. I am having a hard time getting this to work with |
@tylerhutcherson @justin-cechmanek Is there a way i can help with this one? I'd happily remove those if-else statements, but i can't push to this PR. |
We resolved some of our CI/CD issues (due to a buggy |
Reformatting Adding VoyageAI to enum
5a80260
to
516fd33
Compare
At last, after fighting against the gods of CI/CD -- we have something ready and cleaned up to merge. @fzowl @justin-cechmanek Can you all do a review pass please? I will squash this and merge once done. Thanks! @fzowl any plans to build an example or recipe or demo using your new contributions? |
Co-authored-by: Justin Cechmanek <165097110+justin-cechmanek@users.noreply.github.com>
Co-authored-by: Justin Cechmanek <165097110+justin-cechmanek@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have those two lingering if-else blocks, but otherwise this looks good to go
List[List[float]]: List of embeddings. | ||
|
||
Raises: | ||
TypeError: In an invalid input_type is provided. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TypeError: In an invalid input_type is provided. | |
TypeError: If an invalid input_type is provided. |
List[float]: Embedding. | ||
|
||
Raises: | ||
TypeError: In an invalid input_type is provided. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TypeError: In an invalid input_type is provided. | |
TypeError: If an invalid input_type is provided. |
@tylerhutcherson Thank you very much for your effort! Sure, i create a task for myself to write a recipe/demo. |
This PR (thanks to @fzowl) integrates the VoyageAI vectorizer and reranker into the RedisVL client, streamlining access for devs to embed data and rerank search results from Redis.