Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate VoyageAI Vectorizer and Reranker class #223

Merged
merged 21 commits into from
Jan 14, 2025

Conversation

tylerhutcherson
Copy link
Collaborator

This PR (thanks to @fzowl) integrates the VoyageAI vectorizer and reranker into the RedisVL client, streamlining access for devs to embed data and rerank search results from Redis.

@tylerhutcherson tylerhutcherson added the enhancement New feature or request label Sep 21, 2024
@fzowl
Copy link
Contributor

fzowl commented Sep 23, 2024

@tylerhutcherson Thank you very much! Please let me know if i can help you with this.

@fzowl
Copy link
Contributor

fzowl commented Sep 26, 2024

@tylerhutcherson It seems like there is an error in the rerank code, i suggested a change: https://github.com/redis/redis-vl-python/pull/223/files#r1777636350
Can you please take a look?

@tylerhutcherson
Copy link
Collaborator Author

@fzowl We are so close. I am having a hard time getting this to work with hiredis for some reason as it's part of our testing CI matrix here on github. Seems like there's some dependency issue but the root cause is swallowed by the CI server and it just times out. Will keep trying.

@fzowl
Copy link
Contributor

fzowl commented Oct 14, 2024

@tylerhutcherson @justin-cechmanek Is there a way i can help with this one? I'd happily remove those if-else statements, but i can't push to this PR.

@tylerhutcherson
Copy link
Collaborator Author

We resolved some of our CI/CD issues (due to a buggy protobuf dependency) here 201d676 so now I should be able to get this in soon.

@tylerhutcherson tylerhutcherson force-pushed the feat/RAAE-127/voyage-ai-integration branch from 5a80260 to 516fd33 Compare January 13, 2025 15:43
@tylerhutcherson tylerhutcherson requested a review from fzowl January 14, 2025 18:20
@tylerhutcherson
Copy link
Collaborator Author

At last, after fighting against the gods of CI/CD -- we have something ready and cleaned up to merge. @fzowl @justin-cechmanek Can you all do a review pass please? I will squash this and merge once done. Thanks!

@fzowl any plans to build an example or recipe or demo using your new contributions?

tylerhutcherson and others added 2 commits January 14, 2025 14:16
Co-authored-by: Justin Cechmanek <165097110+justin-cechmanek@users.noreply.github.com>
Co-authored-by: Justin Cechmanek <165097110+justin-cechmanek@users.noreply.github.com>
Copy link
Collaborator

@justin-cechmanek justin-cechmanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have those two lingering if-else blocks, but otherwise this looks good to go

List[List[float]]: List of embeddings.

Raises:
TypeError: In an invalid input_type is provided.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TypeError: In an invalid input_type is provided.
TypeError: If an invalid input_type is provided.

List[float]: Embedding.

Raises:
TypeError: In an invalid input_type is provided.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TypeError: In an invalid input_type is provided.
TypeError: If an invalid input_type is provided.

@tylerhutcherson tylerhutcherson merged commit 18d1cfd into main Jan 14, 2025
20 checks passed
@fzowl
Copy link
Contributor

fzowl commented Jan 14, 2025

@tylerhutcherson Thank you very much for your effort! Sure, i create a task for myself to write a recipe/demo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants