gha: update to latest actions #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
andrewhsu
changed the title
JakeSCahill
approved these changes
Dec 11, 2024
JakeSCahill
reviewed
Dec 11, 2024
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| runs-on: ubuntu-22.04 |
There was a problem hiding this comment.
Curious why we set this to a specific version
There was a problem hiding this comment.
Probably for stability. But we should match whatever netlify uses. Do we know what they use?
There was a problem hiding this comment.
conservatively locking to ubuntu-22.04 to keep consistent behavior after ubuntu-latest is updated in coming change: actions/runner-images#10636
related to jira DEVPROD-2450
JakeSCahill
reviewed
Dec 11, 2024
| npm i | ||
| gulp bundle | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-node@v4 |
There was a problem hiding this comment.
The publish release workflow doesn’t use this so I wonder if it’s even needed
ivotron
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jira: DEVPROD-2488
fixed yaml indent syntax, simplified workflow, and updated to latest github actions