-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gha: update to latest actions #235
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8296be6
gha: fix yaml indentation of validate-build.yml
andrewhsu f8f529f
gha: update actions to latest
andrewhsu 6d4fc76
gha: fix yaml indentation of publish-release.yml
andrewhsu c453c26
gha: simplify publish-release
andrewhsu 8b62e57
gha: update to latest actions/cache@v4
andrewhsu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,40 +1,25 @@ | ||
name: Publish Bundle | ||
|
||
--- | ||
name: publish-release | ||
on: | ||
push: | ||
tags: | ||
- v* | ||
|
||
tags: ['v*'] | ||
jobs: | ||
build: | ||
runs-on: ubuntu-latest | ||
|
||
runs-on: ubuntu-22.04 | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v4 | ||
|
||
- name: Cache node_modules | ||
uses: actions/cache@v2 | ||
with: | ||
path: ~/.npm | ||
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }} | ||
restore-keys: | | ||
${{ runner.os }}-node- | ||
|
||
- name: Install Dependencies | ||
run: npm install | ||
|
||
- name: Run Gulp Bundle | ||
run: gulp bundle | ||
|
||
- name: Create Release | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
run: | | ||
gh release create "${{ github.ref_name }}" ./build/ui-bundle.zip \ | ||
--repo="$GITHUB_REPOSITORY" \ | ||
--title="${{ github.ref_name }}" \ | ||
--generate-notes | ||
|
||
- name: Trigger Netlify Build Hook | ||
run: curl -X POST -d {} https://api.netlify.com/build_hooks/64e4682992f9ec30865c7c0b | ||
- uses: actions/checkout@v4 | ||
- uses: actions/cache@v4 | ||
with: | ||
path: ~/.npm | ||
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }} | ||
restore-keys: | | ||
${{ runner.os }}-node- | ||
- run: npm install | ||
- run: gulp bundle | ||
- run: | | ||
gh release create \ | ||
"${{ github.ref_name }}" ./build/ui-bundle.zip --generate-notes | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
- name: Trigger Netlify Build Hook | ||
run: curl -X POST -d {} https://api.netlify.com/build_hooks/64e4682992f9ec30865c7c0b |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,18 @@ | ||
--- | ||
# This workflow makes sure that the UI builds without errors | ||
|
||
name: Validate the build | ||
|
||
name: validate-build | ||
on: | ||
pull_request: | ||
branches: [ main ] | ||
|
||
branches: [main] | ||
jobs: | ||
build: | ||
|
||
runs-on: ubuntu-latest | ||
|
||
runs-on: ubuntu-22.04 | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: actions/setup-node@v1 | ||
with: | ||
node-version: 10 | ||
- name: Bundle UI | ||
run: | | ||
npm i | ||
gulp bundle | ||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-node@v4 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The publish release workflow doesn’t use this so I wonder if it’s even needed |
||
with: | ||
node-version: 10 | ||
- name: Bundle UI | ||
run: | | ||
npm i | ||
gulp bundle |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious why we set this to a specific version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably for stability. But we should match whatever netlify uses. Do we know what they use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conservatively locking to
ubuntu-22.04
to keep consistent behavior afterubuntu-latest
is updated in coming change: actions/runner-images#10636related to jira DEVPROD-2450