Merge pull request #19790 from ztlpn/fix-empty-seg-prefix-truncate

s/disk_log_impl: don't prefix-truncate empty segments
redpanda-data · Jun 12, 2024 · 229c8dd · 229c8dd
2 parents 0ca0de7 + 963ff23
commit 229c8dd
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/v/storage/disk_log_impl.cc b/src/v/storage/disk_log_impl.cc
@@ -2511,7 +2511,12 @@ ss::future<>
 disk_log_impl::remove_prefix_full_segments(truncate_prefix_config cfg) {
     return ss::do_until(
       [this, cfg] {
+          // base_offset check is for the case of an empty segment
+          // (where dirty = base - 1). We don't want to remove it because
+          // batches may be concurrently appended to it and we should keep them.
           return _segs.empty()
+                 || _segs.front()->offsets().get_base_offset()
+                      >= cfg.start_offset
                  || _segs.front()->offsets().get_dirty_offset()
                       >= cfg.start_offset;
       },