s/disk_log_impl: don't prefix-truncate empty segments #19790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider the following sequence of events: 1. there is a single segment in the log, with offsets [0-9] 2. we call prefix_truncate(10) 3. concurrently, another batch of 5 messages is being appended. 4. empty segment with base_offset=10, dirty_offset=9 is created 5. the appended batch is placed at offsets 10-14 Previously, the empty segment would have passed the dirty_offset check and (after waiting for the append to finish) would get deleted (including the data at offsets 10-14). Check also the segment base_offset to prevent that. Fixes redpanda-data#19632
andrwng
approved these changes
Jun 11, 2024
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/50132#019009b0-95f8-46b8-8800-2be603695293 ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/50132#019009b0-95ff-4b18-89f5-2e06688d8860 |
mmaslankaprv
approved these changes
Jun 12, 2024
Good point, usually I'm reluctant to backport similar fixes without reported bugs, but this seems low risk. |
|
/backport v24.1.x |
|
/backport v24.1.x |
This was referenced Jun 12, 2024
|
/backport v23.3.x |
|
Failed to create a backport PR to v23.3.x branch. I tried: |
dotnwat
reviewed
Oct 9, 2024
Comment on lines
+2514
to
+2516
| // base_offset check is for the case of an empty segment | ||
| // (where dirty = base - 1). We don't want to remove it because | ||
| // batches may be concurrently appended to it and we should keep them. |
There was a problem hiding this comment.
yikes. we probably should have had a lot more concurrency limitations in disk_log_impl. another thing that @andrwng's work on local storage v2 would address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the following sequence of events:
Previously, the empty segment would have passed the dirty_offset check and (after waiting for the append to finish) would get deleted (including the data at offsets 10-14). Check also the segment base_offset to prevent that.
Fixes #19632
Backports Required
Release Notes