Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s/disk_log_impl: don't prefix-truncate empty segments #19790

Merged
merged 1 commit into from
Jun 12, 2024
Merged

s/disk_log_impl: don't prefix-truncate empty segments #19790

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/v/storage/disk_log_impl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2511,7 +2511,12 @@ ss::future<>
disk_log_impl::remove_prefix_full_segments(truncate_prefix_config cfg) {
return ss::do_until(
[this, cfg] {
// base_offset check is for the case of an empty segment
// (where dirty = base - 1). We don't want to remove it because
// batches may be concurrently appended to it and we should keep them.
Comment on lines +2514 to +2516
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yikes. we probably should have had a lot more concurrency limitations in disk_log_impl. another thing that @andrwng's work on local storage v2 would address.

return _segs.empty()
|| _segs.front()->offsets().get_base_offset()
>= cfg.start_offset
|| _segs.front()->offsets().get_dirty_offset()
>= cfg.start_offset;
},
Expand Down
Loading