-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[storage]: remove storage::log pimpl wrapper #12544
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches the tree to operate on ss::shared_ptr<log>. This is a purely mechnical preparation for the next commit which will remove the pimpl wrapper around. Making this change first means that the two modifications do not need to be in the same commit. The oddities that arise (e.g. optional<shared_ptr>) will be cleaned-up in a subsequent commit. Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
The get_impl wrapper is removed in the next commit as it is now unnecessary. Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Now that holders of an ss::shared_ptr alreayd have a polymorphic pointer to the underlying implementation there is no need for an extra accessor. Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Now a nullptr can serve the same purpose. Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
dotnwat
changed the title
testing no log pimpl
[storage]: remove storage::log pimpl wrapper
Aug 2, 2023
Not strictly necessary, but a nice safety net since the only users of the log should be holding a shared pointer anyway. Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
andrwng
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last quarter we remove the in-memory implementation, but then we were left with the pimpl wrapper and only one implementation. This PR removes the pimpl wrapper.
ss::shared_ptr<log>
vsusing log_ptr = ss::shared_ptr<log>
- used the former because (1) explicit is nice and (2) outside of tests (ie core redpanda) there are only a handful of places where it is spelled out explicitly such as method parameters.Backports Required
Release Notes