[storage]: storage::log interface self-honesty #12596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Exposes the segment set through the log interface, and removes the dynamic_cast to disk_log_impl. The segment is forward declared as its header includes some bits that wreck compilation due to naming conflicts in other parts of the tree. This will be addressed later. Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Exposes the probe. The probe is forward declared because the probe.h header brings a long some bits that wreck compilation in a few places with naming clases, which will be fixed up later. Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
abhijat
reviewed
Aug 4, 2023
src/v/archival/archival_policy.cc
Outdated
Comment on lines
415
to
417
| vlog( | ||
| archival_log.warn, | ||
| "Upload policy find next compacted segment: cannot find log for ntp: " |
There was a problem hiding this comment.
Should this warning message change, as the condition has changed?
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
andrwng
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been hiding behind
dynamic_castinstead of being honest with ourselves about the unpleasant parts of the log interface. This PR changes that by surfacing the external interfaces to storage::log (it's really not so bad). In any case, the disk_log_builder is now the only remaining user ofdynamic_cast<disk_log_impl>as it uses a bunch of low-level interfaces.This change is important as we look towards evolving the local log implementation--we need to be able to clearly see the interface we are trying to support.
Backports Required
Release Notes