Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v23.2.x] build(deps): bump github.com/Masterminds/semver/v3 from 3.2.0 to 3.2.1 in /src/go/k8s #13184

Merged
merged 2 commits into from
Sep 19, 2023
Merged

[v23.2.x] build(deps): bump github.com/Masterminds/semver/v3 from 3.2.0 to 3.2.1 in /src/go/k8s #13184

merged 2 commits into from
Sep 19, 2023

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #13155

@vbotbuildovich vbotbuildovich added this to the v23.2.x-next milestone Aug 31, 2023
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Aug 31, 2023
andrewhsu
andrewhsu requested changes Sep 6, 2023
View reviewed changes
Copy link
Member

@andrewhsu andrewhsu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

although the changes in src/go/k8s of this PR line up with go mod tidy in that dir, the src/go/cluster-to-redpanda-migration will also need a go mod tidy to update its go.sum file because it depends on src/go/k8s modules.

may be easier to just create a manual backport if this change is desired on the v23.2.x branch.

@dependabot @RafalKorepta
build(deps): bump github.com/Masterminds/semver/v3 in /src/go/k8s
f8571b3 
Bumps [github.com/Masterminds/semver/v3](https://github.com/Masterminds/semver) from 3.2.0 to 3.2.1.
- [Release notes](https://github.com/Masterminds/semver/releases)
- [Changelog](https://github.com/Masterminds/semver/blob/master/CHANGELOG.md)
- [Commits](Masterminds/semver@v3.2.0...v3.2.1)

---
updated-dependencies:
- dependency-name: github.com/Masterminds/semver/v3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
(cherry picked from commit 4d8309d)
@RafalKorepta RafalKorepta force-pushed the backport-pr-13155-v23.2.x-952 branch from ae55ed9 to 345a856 Compare September 8, 2023 08:40
@RafalKorepta RafalKorepta marked this pull request as ready for review September 8, 2023 08:42
@RafalKorepta RafalKorepta requested a review from a team as a code owner September 8, 2023 08:42
@RafalKorepta
Copy link
Contributor

@andrewhsu I run go mod tidy on both src/go/k8s and src/go/cluster-to-redpanda-migration

@joejulian
Copy link
Contributor

No, these are two different projects with two different go.mod files. You can update an upstream dependency (src/go/k8s) without having to bump downstream (translation tool or anybody else that's built a tool from our repo). Let's remove that extra commit.

joejulian
joejulian suggested changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@joejulian joejulian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking to remove unrelated change

andrewhsu
andrewhsu approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@andrewhsu andrewhsu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

EDIT: btw, if you rebase with tip of v23.2.x branch now, you'll bring in changes from PR #13392 which adds gha checks to the PR to validate go

@piyushredpanda
Copy link
Contributor

@joejulian / @ivotron : Who needs to shepherd this in?

@joejulian
Copy link
Contributor

I'll take care of it.

@joejulian joejulian force-pushed the backport-pr-13155-v23.2.x-952 branch from 345a856 to 00e36cd Compare September 19, 2023 15:41
@joejulian joejulian self-assigned this Sep 19, 2023
@joejulian joejulian merged commit 92597d9 into redpanda-data:v23.2.x Sep 19, 2023
9 checks passed
@piyushredpanda piyushredpanda modified the milestones: v23.2.x-next, v23.2.10 Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafalKorepta RafalKorepta RafalKorepta approved these changes

@joejulian joejulian joejulian approved these changes

@andrewhsu andrewhsu andrewhsu approved these changes

Assignees

@joejulian joejulian

Labels
area/k8s kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v23.2.10
Development

Successfully merging this pull request may close these issues.
5 participants
@vbotbuildovich @RafalKorepta @joejulian @piyushredpanda @andrewhsu