Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v23.2.x] gha: run go test on PRs to release branches #13392

Merged
merged 3 commits into from
Sep 12, 2023
Merged

[v23.2.x] gha: run go test on PRs to release branches #13392

merged 3 commits into from
Sep 12, 2023

Conversation

andrewhsu
Copy link
Member

@andrewhsu andrewhsu commented Sep 12, 2023 •
edited
Loading

manual backport of PR #13210

this PR will also help catch missing go mod tidy when the go.mod file is updated, e.g. PR #13359

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.2.x
  • v23.1.x
  • v22.3.x

Release Notes

  • none

@andrewhsu
gha: test cluster-to-redpanda-migration on PRs
74f9442 
(cherry picked from commit fdc76a2)

Conflicts:
	.github/workflows/redpanda-migration-build.yml

resolved by taking the chuck that adds the `paths` section
@andrewhsu
gha: test rpk on PRs
f9d53a0 
(cherry picked from commit 34221a1)

Conflicts:
	.github/workflows/rpk-build.yml

resolved by taking the chuck that adds the `paths` section
@andrewhsu
Copy link
Member Author

ready for review

@andrewhsu andrewhsu marked this pull request as ready for review September 12, 2023 17:00
@andrewhsu andrewhsu requested a review from a team as a code owner September 12, 2023 17:00
@andrewhsu andrewhsu requested review from ivotron and removed request for a team September 12, 2023 17:00
ivotron
ivotron approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@ivotron ivotron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm assuming green checkmarks for affected tests

@andrewhsu
Copy link
Member Author

known failure is unrelated to this PR's changes:

@andrewhsu andrewhsu merged commit 63f6153 into redpanda-data:v23.2.x Sep 12, 2023
22 checks passed
@andrewhsu andrewhsu deleted the v23.2.x-go-test-pr branch September 12, 2023 19:45
@andrewhsu andrewhsu mentioned this pull request Sep 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivotron ivotron ivotron approved these changes

@RafalKorepta RafalKorepta Awaiting requested review from RafalKorepta

Assignees
No one assigned
Labels
area/build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewhsu @ivotron