Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v23.2.x] [backport] tx: add more trace logging in init_producer_id code path #14448

Merged
merged 5 commits into from
Oct 26, 2023
Merged

[v23.2.x] [backport] tx: add more trace logging in init_producer_id code path #14448

merged 5 commits into from
Oct 26, 2023

Conversation

bharathv
Copy link
Contributor

@bharathv bharathv commented Oct 25, 2023 •
edited by mmaslankaprv
Loading

Backport of PR #14401
Backport of PR #14420

Fixes: #14437
Fixes: #14463

@bharathv bharathv added this to the v23.2.x-next milestone Oct 25, 2023
@bharathv bharathv requested a review from mmaslankaprv October 26, 2023 02:25
@bharathv
tx: add more traace logging in init_producer_id code path
3a695bb 
(cherry picked from commit 745d516)
@bharathv
tm_stm: use a prefix logger with ntp information
e9a92db 
with more than one partition for tx topic, we need to be able to
distinguish logs between different partitions.

(cherry picked from commit 6498739)
@bharathv
k/server: include tx_id during failed pid allocation
bb59a69
@bharathv bharathv force-pushed the v232x-more-tx-logging branch from 469898b to bb59a69 Compare October 26, 2023 15:52
@bharathv bharathv requested a review from mmaslankaprv October 26, 2023 15:52
@mmaslankaprv
tx_gateway: renamed get_ntp method
91dc5dc 
Renamed `get_ntp` to `ntp_for_tx_id` to better reflect the purpose of
this method

Signed-off-by: Michal Maslanka <michal@redpanda.com>
(cherry picked from commit bc1059f)
@mmaslankaprv mmaslankaprv linked an issue Oct 26, 2023 that may be closed by this pull request
[v23.2.x] c/tx_gt_frontend: do not retry when not leader for tx topic partition #14463
Closed
@mmaslankaprv mmaslankaprv force-pushed the v232x-more-tx-logging branch from 9b83890 to 9dfbafa Compare October 26, 2023 17:24
@mmaslankaprv
c/tx_gt_frontend: do not retry when not leader for tx topic partition
80ed295 
Changed the logic in `init_tm_tx` not to retry when current node is not
leader for partition hosting particular transactional id. Previously
when current node wasn't a leader for partition host the transactional
id the logic retired finding `tx_id` hosting `ntp` in the same way as it
would be missing in metadata cache.

Signed-off-by: Michal Maslanka <michal@redpanda.com>
(cherry picked from commit f1b96f0)
@mmaslankaprv mmaslankaprv force-pushed the v232x-more-tx-logging branch from 9dfbafa to 80ed295 Compare October 26, 2023 17:41
@bharathv bharathv merged commit b5a8b9a into redpanda-data:v23.2.x Oct 26, 2023
9 checks passed
@bharathv bharathv deleted the v232x-more-tx-logging branch October 26, 2023 19:35
@joejulian joejulian mentioned this pull request Oct 30, 2023
Merged
@BenPope BenPope modified the milestones: v23.2.x-next, v23.2.14 Oct 30, 2023
@github-actions github-actions bot mentioned this pull request Oct 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmaslankaprv mmaslankaprv mmaslankaprv approved these changes

Assignees
No one assigned
Labels
area/redpanda
Projects
None yet
Milestone
v23.2.14
Development

Successfully merging this pull request may close these issues.

[v23.2.x] c/tx_gt_frontend: do not retry when not leader for tx topic partition
3 participants
@bharathv @mmaslankaprv @BenPope