Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v23.3.x] allow property aliases in redpanda.yaml, fix aliases not being applied #15760

Merged
merged 6 commits into from
Dec 19, 2023
Merged

[v23.3.x] allow property aliases in redpanda.yaml, fix aliases not being applied #15760

merged 6 commits into from
Dec 19, 2023

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #15605
Fixes: #15759,

andijcr and others added 6 commits December 19, 2023 06:45
@andijcr @vbotbuildovich
config/config_store: handle aliases for property names
ba02178 
before this commit, finding the name in the alias table would not throw
the std::invalid_argument exception. but would not set the property.

(cherry picked from commit f8a1ebf)
@andijcr @vbotbuildovich
config/config_store: intermediary commit to remove an indentation level
ef75ff0 
this is a non-functional change

(cherry picked from commit f0e8f8a)
@andijcr @vbotbuildovich
config/config_store: optional to ptr
e3b3b21 
non functional change, the optional was just used inside a code block

(cherry picked from commit 35ed706)
@andijcr @vbotbuildovich
config/config_store property_aliases() property_names_and_aliases()
87c58da 
property_aliases() mirrors property_names()
and both get merged in property_names_and_aliases(), to be used instead
of property_names when filtering/scanning over user input

(cherry picked from commit bebf4aa)
@andijcr @vbotbuildovich
config: use property_names_and_aliases()
1646b51 
this allows to include prop aliases when validating external input

(cherry picked from commit b025e34)
@andijcr @vbotbuildovich
config/config_store_test: unit testing for aliases in yaml source
7ee6b61 
(cherry picked from commit b76f908)
@vbotbuildovich vbotbuildovich added this to the v23.3.x-next milestone Dec 19, 2023
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Dec 19, 2023
@andijcr andijcr marked this pull request as ready for review December 19, 2023 07:09
@andijcr
Copy link
Contributor

andijcr commented Dec 19, 2023

/dt

@andijcr
Copy link
Contributor

andijcr commented Dec 19, 2023 •
edited
Loading

this pr needs #15734 to merge. it's not a strict requirements, this pr makes #15263 deterministically fail and the fix is in 15734

@andijcr
Copy link
Contributor

andijcr commented Dec 19, 2023

issues will be fixed by #15734

@piyushredpanda piyushredpanda merged commit fa1c44d into redpanda-data:v23.3.x Dec 19, 2023
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andijcr andijcr andijcr approved these changes

@dotnwat dotnwat Awaiting requested review from dotnwat

@StephanDollberg StephanDollberg Awaiting requested review from StephanDollberg

@graphcareful graphcareful Awaiting requested review from graphcareful

Assignees
No one assigned
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v23.3.1-rc5
Development

Successfully merging this pull request may close these issues.
3 participants
@vbotbuildovich @andijcr @piyushredpanda