Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v23.2.x] demote ERROR message to DEBUG for timequerys at the edge of spillover retention #16312

Merged
merged 5 commits into from
Feb 5, 2024
Merged

[v23.2.x] demote ERROR message to DEBUG for timequerys at the edge of spillover retention #16312

merged 5 commits into from
Feb 5, 2024

Conversation

andijcr
Copy link
Contributor

@andijcr andijcr commented Jan 26, 2024

Backport of PR #16302

Fixes #16305

@andijcr
cloud_storage/remote_partition: remove unused variable
1b79608 
(cherry picked from commit 79585cd)
(cherry picked from commit b34c114)
@andijcr
cloud_storage/async_manifest_view: remove redundant call to in_stm
19fff6a 
prev if block is a bouncer condition in the form if(is_stm(q)) so it's
assured (!in_stm(q))

(cherry picked from commit ecc24d2)
(cherry picked from commit 399406b)
@andijcr
cloud_storage/async_manifest_view: log message fix
a6e1f90 
(cherry picked from commit b7a7926)
(cherry picked from commit a28c731)
@andijcr
cloud_storage/remote_partition: refactor variant access to use ss::visit
b28d499 
(cherry picked from commit 9a541f6)
@andijcr
cloud_storage/remote_partition: handle race retention+timequery
856b784 
log a warning if when trying to get a async_manifest_view_cursor for a
timequery the result is out_of_range.
such error can happen if retention is kicking in and deleting some or
all spillover manifests: in this case there is a window where the
manifest are reclaimable but still kept in memory, and the timequery
hits one of the manifest in the reclaimable range.

handling this as a warning and no result is acceptable because the kafka
client issuing the request can handle this failure, and otherwise
handling this edge cases would increase the complexity of the callstack

(cherry picked from commit 4ca7281)
@andijcr andijcr added the kind/backport PRs targeting a stable branch label Jan 26, 2024
@andijcr andijcr requested a review from Lazin January 26, 2024 19:27
@mergify mergify bot mentioned this pull request Jan 26, 2024
Closed
@abhijat
Copy link
Contributor

abhijat commented Jan 29, 2024

/ci-repeat

@andijcr
Copy link
Contributor Author

andijcr commented Jan 29, 2024 •
edited
Loading

this failure is triggering #8217

but the issue is different (and the fix for that ticket is in this branch)
the test looks for this message

ERASE_ERROR_MSG = "Inconsistency detected between KVStore last_applied"

in the log to signal that an inconsistency has been detected, but it does not appear in the log.

this should be unrelated to this pr,since this is just an error -> debug conversion

@andijcr andijcr linked an issue Jan 30, 2024 that may be closed by this pull request
[v23.2.x] demote ERROR message to DEBUG for timequerys at the edge of spillover retention #16305
Closed
@piyushredpanda
Copy link
Contributor

Merging given the above comment.

@piyushredpanda piyushredpanda merged commit 22a0000 into redpanda-data:v23.2.x Feb 5, 2024
20 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhijat abhijat abhijat approved these changes

@Lazin Lazin Awaiting requested review from Lazin

Assignees
No one assigned
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v23.2.x] demote ERROR message to DEBUG for timequerys at the edge of spillover retention
3 participants
@andijcr @abhijat @piyushredpanda