Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-1752: cst: Downgrade error logs to debug #17828

Conversation

abhijat
Copy link
Contributor

@abhijat abhijat commented Apr 12, 2024

Recently added error logs do not take into account sleep aborted and other shutdown related errors. Since the logs print exception details which are already logged down the call chain, and the new logs are for debugging hang in chunk read path, the new logs are downgraded to debug level in this change.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

  • none

Recently added error logs do not take into account sleep aborted and
other shutdown related errors. Since the logs print exception details
which are already logged down the call chain, and the new logs are for
debugging hang in chunk read path, the new logs are downgraded to debug
level in this change.
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Apr 12, 2024

@dotnwat
Copy link
Member

dotnwat commented Apr 12, 2024

@abhijat did you intend to request reviews?

@abhijat abhijat requested review from Lazin and andijcr April 23, 2024 06:06
@abhijat abhijat merged commit 1f58989 into redpanda-data:dev Apr 23, 2024
18 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.2.x

@ztlpn
Copy link
Contributor

ztlpn commented May 2, 2024

Looks like this was merged after branching so needs a backport to 24.1 too

@ztlpn
Copy link
Contributor

ztlpn commented May 2, 2024

/backport v24.1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants