Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-2742 post review updates #18197

Merged
merged 2 commits into from
May 7, 2024
Merged

CORE-2742 post review updates #18197

merged 2 commits into from
May 7, 2024

Conversation

michael-redpanda
Copy link
Contributor

Updates from post review comments in #17616

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

  • none

@michael-redpanda
node_config: Updated wording to fips_mode flag
715cead 
Signed-off-by: Michael Boquard <michael@redpanda.com>
@michael-redpanda
app: Removed printing value of fips_enabled file
9e3264c 
It's possible, however unlikely, that the fips_enabled file
would return a non-printable character.  Just in case it does,
let's not print it in case it isn't '1'.

Signed-off-by: Michael Boquard <michael@redpanda.com>
@michael-redpanda michael-redpanda requested a review from a team as a code owner May 1, 2024 18:38
@michael-redpanda michael-redpanda requested review from a team and graphcareful and removed request for a team May 1, 2024 18:38
@michael-redpanda michael-redpanda self-assigned this May 1, 2024
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented May 1, 2024 •
edited
Loading

new failures in https://buildkite.com/redpanda/redpanda/builds/48573#018f35c8-721a-4772-91b9-d6ec57982824:

"rptest.tests.read_replica_e2e_test.ReadReplicasUpgradeTest.test_upgrades.cloud_storage_type=CloudStorageType.S3"

new failures in https://buildkite.com/redpanda/redpanda/builds/48573#018f35c8-721d-44d4-a9ae-29998cdc69c3:

"rptest.tests.upgrade_test.UpgradeFromPriorFeatureVersionCloudStorageTest.test_rolling_upgrade.cloud_storage_type=CloudStorageType.S3"

new failures in https://buildkite.com/redpanda/redpanda/builds/48573#018f35d0-78a8-44f3-b504-cfcfba3e80bd:

"rptest.tests.read_replica_e2e_test.ReadReplicasUpgradeTest.test_upgrades.cloud_storage_type=CloudStorageType.S3"
"rptest.tests.partition_movement_test.SIPartitionMovementTest.test_cross_shard.num_to_upgrade=2.cloud_storage_type=CloudStorageType.S3"
"rptest.tests.partition_movement_test.SIPartitionMovementTest.test_shadow_indexing.num_to_upgrade=2.cloud_storage_type=CloudStorageType.S3"

new failures in https://buildkite.com/redpanda/redpanda/builds/48573#018f35d0-78b0-47a7-9703-a2c435fffaf9:

"rptest.tests.upgrade_test.UpgradeFromPriorFeatureVersionCloudStorageTest.test_rolling_upgrade.cloud_storage_type=CloudStorageType.S3"

new failures in https://buildkite.com/redpanda/redpanda/builds/48763#018f50fe-65c7-4706-a2f2-1f6869b985aa:

"rptest.tests.e2e_shadow_indexing_test.EndToEndThrottlingTest.test_throttling.cloud_storage_type=CloudStorageType.S3"

new failures in https://buildkite.com/redpanda/redpanda/builds/48763#018f50fe-65c5-48aa-9df4-8da98238fe27:

"rptest.tests.e2e_shadow_indexing_test.EndToEndThrottlingTest.test_throttling.cloud_storage_type=CloudStorageType.ABS"

new failures in https://buildkite.com/redpanda/redpanda/builds/48763#018f5106-34f6-4206-afe3-9ceb73198c9e:

"rptest.tests.e2e_shadow_indexing_test.EndToEndThrottlingTest.test_throttling.cloud_storage_type=CloudStorageType.S3"

new failures in https://buildkite.com/redpanda/redpanda/builds/48763#018f5106-34f3-4cc7-b57c-785af571f118:

"rptest.tests.e2e_shadow_indexing_test.EndToEndThrottlingTest.test_throttling.cloud_storage_type=CloudStorageType.ABS"

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented May 1, 2024 •
edited
Loading

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/48573#018f35d0-78a8-44f3-b504-cfcfba3e80bd

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/48573#018f35d0-78ac-4e0a-b675-f034e0c7c998

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/48763#018f50fe-65c7-4706-a2f2-1f6869b985aa

@dotnwat
Copy link
Member

dotnwat commented May 7, 2024

/ci-repeat 1

@michael-redpanda
Copy link
Contributor Author

CI Issues:

@michael-redpanda michael-redpanda merged commit 11c0cb8 into redpanda-data:dev May 7, 2024
13 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphcareful graphcareful graphcareful approved these changes

@dotnwat dotnwat dotnwat approved these changes

Assignees

@michael-redpanda michael-redpanda

Labels
area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michael-redpanda @vbotbuildovich @dotnwat @graphcareful