Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-2742 post review updates #18197

Merged
merged 2 commits into from
May 7, 2024
Merged

CORE-2742 post review updates #18197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
715cead
node_config: Updated wording to fips_mode flag
michael-redpanda May 1, 2024
9e3264c
app: Removed printing value of fips_enabled file
michael-redpanda May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/v/config/node_config.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,8 @@ node_config::node_config() noexcept
"file does not exist or does not return '1', Redpanda immediately "
"exits. After the check is complete, Redpanda loads the "
"OpenSSL FIPS provider into the OpenSSL library. After this is "
"complete, Redpanda is operating in FIPS mode. This means that the "
"available TLS cipher suites available to users are limited to TLSv1.2 "
"complete, Redpanda is operating in FIPS mode, which means that the "
"TLS cipher suites available to users are limited to TLSv1.2 "
"and TLSv1.3, and of those, only the ones that use NIST-approved "
"cryptographic methods. For more information about FIPS, refer to "
"Redpanda documentation.",
Expand Down
7 changes: 3 additions & 4 deletions src/v/redpanda/application.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -899,10 +899,9 @@ void application::check_environment() {
fd.read(buf, 1);
if (buf[0] != '1') {
throw std::runtime_error(fmt::format(
"File '{}' not reporting '1': '{}'. Redpanda cannot start in "
"FIPS mode",
fips_enabled_file,
std::string(&buf[0], 1)));
"File '{}' not reporting '1'. Redpanda cannot start in FIPS "
"mode",
fips_enabled_file));
}
syschecks::systemd_message("Starting Redpanda in FIPS mode").get();
}
Expand Down
Loading