Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

archival: Disable housekeeping jobs on startup #18526

Merged
merged 1 commit into from
May 16, 2024
Merged

archival: Disable housekeeping jobs on startup #18526

merged 1 commit into from
May 16, 2024

Conversation

Lazin
Copy link
Contributor

@Lazin Lazin commented May 16, 2024 •
edited
Loading

When the archiver is created there is a small window of opportunity for it to run some housekeeping jobs before the manifest is synced. This commit disables the housekeeping jobs in the constructor to avoid this.

Fixes #18482
Fixes #18386
Fixes #18385
Fixes #18384
Fixes #18381
Fixes #18312
Fixes #18254
Fixes #18031
Fixes #17986
Fixes #17916
Fixes #17753
Fixes #17752
Fixes #17510
Fixes #17412
Fixes #17366
Fixes #17364
Fixes #14221
Fixes #13995

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

  • None

@Lazin
archival: Disable housekeeping jobs on startup
d4735bc 
When the archiver is created there is a small window of opportunity for
it to run some housekeeping jobs before the manifest is synced. This
commit disables the housekeeping jobs in the contstructor to avoid this.
@Lazin Lazin requested a review from abhijat May 16, 2024 13:43
abhijat
abhijat approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@abhijat abhijat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change lgtm but might be good to add a comment to describe why we disable these here and enable later on

@WillemKauf
Copy link
Contributor

Given the proximity to the other failed tests, I wonder if this also fixes #17201 (comment).

@Lazin
Copy link
Contributor Author

Lazin commented May 16, 2024

/ci-repeat 10

@Lazin
Copy link
Contributor Author

Lazin commented May 16, 2024

The change lgtm but might be good to add a comment to describe why we disable these here and enable later on

The description is in the commit message

@Lazin
Copy link
Contributor Author

Lazin commented May 16, 2024

Given the proximity to the other failed tests, I wonder if this also fixes #17201 (comment).

from the first glance it doesn't look related

andrwng
andrwng approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@andrwng andrwng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented May 16, 2024 •
edited
Loading

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/49242#018f82de-7dbf-4f13-b4f6-95a56e869581

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/49242#018f82de-7db2-4336-b793-87b94221c637

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/49242#018f82de-7db2-4cc9-8a01-163136df086f

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/49242#018f82de-7dc3-402e-a097-a479bc6f4133

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/49242#018f82e5-c45f-46dd-bc17-f24c7b231aaa

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/49242#018f82e5-c45d-4262-b3e5-625169479fa4

@Lazin Lazin merged commit 232c295 into redpanda-data:dev May 16, 2024
20 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v24.1.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

This was referenced May 16, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced May 16, 2024
Closed
Closed
Closed
Closed
@vbotbuildovich
Copy link
Collaborator

Oops! Something went wrong.

Workflow run logs.

@vbotbuildovich
Copy link
Collaborator

Oops! Something went wrong.

Workflow run logs.

@Lazin
Copy link
Contributor Author

Lazin commented May 21, 2024

/backport v24.1.x

@Lazin
Copy link
Contributor Author

Lazin commented May 21, 2024

/backport v23.3.x

This was referenced May 21, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrwng andrwng andrwng approved these changes

@abhijat abhijat abhijat approved these changes

Assignees
No one assigned
Labels
area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI Failure (key symptom) in EndToEndSpilloverTest.test_spillover CI Failure (key symptom) in EndToEndThrottlingTest.test_throttling CI Failure (New replacement segment has the same size as replaced segment) in ManyPartitionsTest.test_many_partitions_tiered_storage CI Failure (Bad Log Lines: New segment has same size) in CloudStorageUsageTest.test_cloud_storage_usage_reporting_with_partition_moves CI Failure (New replacement segment has the same size as replaced segment) in CloudRetentionTimelyGCTest.test_retention_with_node_failures
CI Failure (key symptom) in ShortLivedCredentialsTests.test_short_lived_credentials CI Failure (New replacement segment has the same size as replaced segment) in CloudRetentionTimelyGCTest.test_retention_with_node_failures CI Failure (New replacement segment has the same size as replaced segment) in EndToEndThrottlingTest.test_throttling [v23.3.x] CI Failure (New replacement segment has the same size as replaced segment) in CloudStorageTimingStressTest.test_cloud_storage_with_partition_moves CI Failure (New replacement segment has the same size as replaced segment) in EndToEndSpilloverTest.test_spillover
5 participants
@Lazin @WillemKauf @vbotbuildovich @abhijat @andrwng