Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: bazel foundation #19946

Closed
wants to merge 128 commits into from
Closed

build: bazel foundation #19946

wants to merge 128 commits into from

Conversation

dotnwat
Copy link
Member

@dotnwat dotnwat commented Jun 21, 2024 •
edited
Loading

This PR is replaced by #20849.

Bazel build foundation.

https://redpandadata.atlassian.net/wiki/x/4wCZKg

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

  • none

@dotnwat
bytes: reference header in current directory
7eebf73 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: add third party dependencies
281b8c9 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: build wrapper
9895d33 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: add baes library bazel build
39d3d9a 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: add ssx library bazel build
61a0fe1 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: add strings library bazel build
65ffd83 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: add bytes library bazel build
80802ae 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: add container library bazel build
e5aa44f 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: add utils library bazel build
06ff960 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: add crypto library bazel build
b90e0ca 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: add random library bazel build
2b47fbd 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: add serde library bazel build
b8d3ed2 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: add test_utils library bazel build
e8efde5 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: update seastar and add config options
6826627 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: add missing hwloc depdendency
e2fcf0a 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: use label conditions
be287e1 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: use inherited c++ standard setting
e58bd47 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: clarify seastar build comments
f9319a1 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: make strings library fine grained
82e7954 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: add no-seastar boost test macro
4e96dcc 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: add strings library tests
bbfde7d 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: add crypto tests
9a1f8e6 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: make random library more fine grained
b52e2a7 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: add random library tests
169f910 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: allow defines to pass through for test macro
ddd4cbd 
Useful for passing in BOOST_TEST_MODULE=foo to add a main().

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: add tests to utils library
cc035b8 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: add base outcome test
01abe7a 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
Merge remote-tracking branch 'origin/dev' into bazel
0bbd40e
@dotnwat
bazel: use a better name for seastar numactl option
075f5eb 
The config option `--@seastar//:numa=True` didn't read very intuitively,
so changed it to `numactl`.

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: add ssx tests
1fcd770 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: remove whitespace
107ed92 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
Merge pull request #20 from dotnwat/pciaccess-warnings
95a8172 
Pciaccess warnings
@dotnwat
bazel: add utils:inet_address library
023445c 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: add schema_registry:config library
ff8a6ae 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: add storage:config library
65e2f6d 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: add serde:chrono library
20be636 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
Merge remote-tracking branch 'origin/dev' into bazel-config
68c5582
@dotnwat
bazel: add serde:bool_class library
2f5dc42 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: add missing serde deps to model library
c2d71fb 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: remove rw/vector from generic serde library
5393109 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: add security:config library
4281447 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: add config library
c83f8f4 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
StephanDollberg
StephanDollberg reviewed Jul 3, 2024
View reviewed changes
.bazelrc
build:release --compilation_mode opt
build:release --config=secure
build:release --copt -mllvm --copt -inline-threshold=2500
build:release --linkopt=-flto
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this gets enabled in the current release build (and also I don't think it would do anything)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thin-lto? i added it by request of @rockwotj, i'll let him chime in. good point about it not being used in the current build!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My intent was to preserve this behavior:

redpanda/src/v/redpanda/CMakeLists.txt

Line 90 in 93474b7

set_property(TARGET redpanda PROPERTY INTERPROCEDURAL_OPTIMIZATION ON)

Does that line to something different or am I misunderstanding what that does?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that quoted like from cmake applies to only the final binary linking, and doesn't take affect transitively across the entire tree, but would need to be enabled globally to have an affect. i'm also not sure i know what i'm talking about :P

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was referring to the vtools build yeah. It needs to be enabled for the compile steps as well yeah. I think passing it only at link time does have some effect like it being able to remove unused functions from the final binary but it's not the full thing that people usually expect.

Hadn't seen that bit in the public build. Are we sure that actually evaluates to true? Just had a quick look and it doesn't get passed for the compile steps at least (not sure whether that is what that cmake logic would do or not).

.bazelrc Show resolved Hide resolved
@dotnwat
Merge remote-tracking branch 'origin/dev' into bazel
68cd642
@dotnwat
bazel: add bench tag to benchmark tests
f03a6e0 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: fix compression tests settings
0dece98 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: add some shortcuts for running tests
3149a21 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: add missing dependencies
14c4467 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: add bracket-include hack for re2 dependency
34e9296 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: print out test errors
786c500 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: add github action to build with bazel
4cd0421 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
Merge remote-tracking branch 'origin/dev' into bazel
42e5112
@dotnwat
bazel: add third party build origin stories
f28c1e1 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bazel: add stack-clash-protection flag to seastar
79739bc 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@mergify mergify bot mentioned this pull request Jul 4, 2024
Closed
7 tasks
@dotnwat dotnwat closed this Jul 4, 2024
@dotnwat dotnwat mentioned this pull request Jul 4, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanDollberg StephanDollberg StephanDollberg left review comments

@rockwotj rockwotj rockwotj left review comments

@michael-redpanda michael-redpanda Awaiting requested review from michael-redpanda michael-redpanda will be requested when the pull request is marked ready for review michael-redpanda is a code owner

Assignees
No one assigned
Labels
area/build area/redpanda area/wasm WASM Data Transforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dotnwat @emaxerrno @StephanDollberg @rockwotj @mmaslankaprv