Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: bazel foundation #19946
build: bazel foundation #19946
Changes from 117 commits
7eebf73
281b8c9
9895d33
39d3d9a
61a0fe1
65ffd83
80802ae
e5aa44f
06ff960
b90e0ca
2b47fbd
b8d3ed2
e8efde5
6826627
e2fcf0a
be287e1
e58bd47
f9319a1
82e7954
4e96dcc
bbfde7d
9a1f8e6
b52e2a7
169f910
ddd4cbd
cc035b8
01abe7a
0bbd40e
075f5eb
1fcd770
fad3b00
d698141
329d13a
590810f
a89af08
ca22e2b
2887843
f5da85d
f2ec24e
b5d51b7
ed9ba45
ad42e34
ee8e91d
ecc8b4d
5819f3c
5563372
b4e9c43
4080858
fa29de0
8007cc2
745a230
2f255c9
0f7fd32
5305841
a7e178f
9bc2053
fed5d40
b813457
d61347e
22bc0c0
538f55a
21b9683
53a08f3
e41c776
52e690b
f193188
ea828bc
baa87be
4302062
f9678d2
dbc06de
7cefc24
83c1c21
c2db0a8
69110a4
a79fb21
8912807
97a9e9a
5dcaaf5
a9b8a88
29982fe
ec7a722
1f5145b
956faf7
f5a2039
8958c57
f1c0574
0e3c42d
4505f93
d5e38a1
20ec04c
00e29d5
8b74a72
f862f7b
b813371
e6d916a
8484270
7985abd
52d8d53
be81892
1554594
eeeda55
aecf8d1
dbadf9b
7304569
107ed92
95a8172
023445c
ff8a6ae
65e2f6d
20be636
68c5582
2f5dc42
c2d71fb
5393109
4281447
c83f8f4
68cd642
f03a6e0
0dece98
3149a21
14c4467
34e9296
786c500
4cd0421
42e5112
f28c1e1
79739bc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this gets enabled in the current release build (and also I don't think it would do anything)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thin-lto? i added it by request of @rockwotj, i'll let him chime in. good point about it not being used in the current build!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My intent was to preserve this behavior:
redpanda/src/v/redpanda/CMakeLists.txt
Line 90 in 93474b7
Does that line to something different or am I misunderstanding what that does?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is that quoted like from cmake applies to only the final binary linking, and doesn't take affect transitively across the entire tree, but would need to be enabled globally to have an affect. i'm also not sure i know what i'm talking about :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was referring to the vtools build yeah. It needs to be enabled for the compile steps as well yeah. I think passing it only at link time does have some effect like it being able to remove unused functions from the final binary but it's not the full thing that people usually expect.
Hadn't seen that bit in the public build. Are we sure that actually evaluates to true? Just had a quick look and it doesn't get passed for the compile steps at least (not sure whether that is what that cmake logic would do or not).