Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v24.1.x] cst/ducktape: Change assertion for deleted chunks #21434

Merged
merged 1 commit into from
Jul 18, 2024
Merged

[v24.1.x] cst/ducktape: Change assertion for deleted chunks #21434

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions tests/rptest/tests/cloud_storage_chunk_read_path_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,12 +229,6 @@ def test_read_chunks(self):
self._assert_not_in_cache(
fr'.*kafka/{self.topic}/.*\.log\.[0-9]+$')

# We cannot assert that there are chunks in cache because the deleting thread
# could delete them all before we run the assertion, causing it to fail.
# We can check that the thread deleted some chunks.
assert rm_chunks.deleted_chunks > 0, "Expected to delete some chunk files during rand-cons, none deleted"
rm_chunks.deleted_chunks = 0

consumer = KgoVerifierSeqConsumer(self.test_context,
self.redpanda,
self.topic,
Expand All @@ -244,7 +238,7 @@ def test_read_chunks(self):
consumer.wait(timeout_sec=120)
rm_chunks.stop()
rm_chunks.join(timeout=10)
assert rm_chunks.deleted_chunks > 0, "Expected to delete some chunk files during seq-cons, none deleted"
assert rm_chunks.deleted_chunks > 0, "Expected to delete some chunk files, none deleted"

self._assert_not_in_cache(
fr'.*kafka/{self.topic}/.*\.log\.[0-9]+$')
Expand Down
Loading